Merged
Conversation
Persist receiver input context across replayed payjoin states Store receiver-contributed input identity in session state and reuse it when replaying WantsFeeRange and ProvisionalProposal. Restrict proposal signing/finalization to receiver-contributed inputs, clear sender finalization and partial sigs, and validate that replayed proposals still contain the expected receiver inputs. Also tighten receiver change selection to fresh Change scripts, bound relay polling with a request timeout, and improve contribution failure diagnostics.
chavic
approved these changes
Apr 12, 2026
Collaborator
chavic
left a comment
chavic
left a comment
There was a problem hiding this comment.
This looks like a useful improvement for replaying the in-memory receiver session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist receiver input context across replayed payjoin states.
Store receiver-contributed input identity in session state and reuse it when replaying WantsFeeRange and ProvisionalProposal. Restrict proposal signing/finalization to receiver-contributed inputs, clear sender finalization and partial sigs, and validate that replayed proposals still contain the expected receiver inputs. Also tighten receiver change selection to fresh Change scripts, bound relay polling with a request timeout, and improve contribution failure diagnostics.