test: Refactor Payjoin integration tests & helpers#1
Merged
Conversation
chavic
approved these changes
Apr 2, 2026
Collaborator
chavic
left a comment
There was a problem hiding this comment.
I’m okay with this as a consistency refactor around the plugin’s current behavior. My main concern was making sure we weren’t accidentally turning timeout into the intended contract for already-paid, expired, and invalid invoice cases. Since those paths are still explicitly marked as TODO pending clean in-flight session closure support in the payjoin library, this makes sense to me as an intermediate step. Approving with the expectation that we’ll tighten these cases later once the underlying receiver rejection behavior is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing negative integration test for Invalid invoices and cleans up the related payjoin failure coverage.
Included in this change
Notes
These tests currently assert the observable behavior as it exists today: the external payjoin payer times out after the invoice becomes non-payable.
Each test keeps a TODO to tighten this to an explicit fast rejection once the payjoin library supports clean in-flight session rejection.