Add support for passing group context to silenceMessage
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinH
reviewed
Mar 16, 2023
|
One test is failing though. |
If a message is contained within a `console.group` or `console.groupCollapsed` call then track this context and provide to implementations of `silenceMessage`. Because groups can be recursively nested, track both the parent group and the full group stack.
lennym
force-pushed
the
lennym/add-group-context
branch
from
bf57d17
to
9601811
Compare
|
I forgot to add the files! 🤦 Should be ok now. |
|
Thanks for this contribution. I'll publish the new version as soon as I'm on the computer. |
|
Fantastic! Thank you so much for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a message is contained within a
console.grouporconsole.groupCollapsedcall then track this context and provide to implementations ofsilenceMessage.Because groups can be recursively nested, track both the parent group and the full group stack.