Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param to skip test names when specified #25

Merged
merged 4 commits into from
Aug 24, 2022

Conversation

lws803
Copy link
Contributor

@lws803 lws803 commented Aug 24, 2022

Allows specification of a skipTestNames parameter to skip test names from erroring out

@ValentinH
Copy link
Owner

Thanks for this addition, could you also update the index.d.ts file please to add the new option?

@lws803
Copy link
Contributor Author

lws803 commented Aug 24, 2022

Thanks for this addition, could you also update the index.d.ts file please to add the new option?

Added here as requested 😄 60624af

Copy link
Owner

@ValentinH ValentinH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion to make the type correct

index.d.ts Outdated
/**
* This parameter lets you define a list of test names to skip console checks for.
*/
skipTestNames?: []
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
skipTestNames?: []
skipTestNames?: string[]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops my bad, cc2bdc4 thanks for the suggestion!

@ValentinH ValentinH merged commit f716c48 into ValentinH:main Aug 24, 2022
@ValentinH
Copy link
Owner

Thanks for this contribution. This was released as https://github.com/ValentinH/jest-fail-on-console/releases/tag/v2.5.0 🎉 🚀

@lws803 lws803 deleted the feature-to-skip-test-names branch August 24, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants