Added pajama data generation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Sample Co-authored-by: blackadder <scope.denis@mail.ru>
…-Sample Co-authored-by: blackadder <scope.denis@mail.ru>
src/datautils.py
Outdated
| data = torch.load(f"./data/red_pajama_n=1024_{seqlen}_context_length.pth")[:nsamples] | ||
| elif name.lower() == "refinedweb": | ||
|
|
||
| if name.lower() == "refinedweb": | ||
| data = torch.load("./data/refined_web_n=128.pth")[:nsamples] |
There was a problem hiding this comment.
I'd recommend that we remove refinedweb since we don't even know what it was tokenized with. If user really wants that dataset, they can directly set DATASET="./data/refined_web_n=128.pt" from CLI
There was a problem hiding this comment.
Do we really intend to work with Falcon models?
There was a problem hiding this comment.
we may eventually need 'em, but the user can still run falcon via DATASET=./data/... as long as they know what they're doing.
My concern is that someone might accidentally try training llama/mistral on main.py "refinedweb" without realizing it's model-specific
Co-authored-by: blackadder <scope.denis@mail.ru>
Co-authored-by: blackadder <scope.denis@mail.ru>
Co-authored-by: blackadder <scope.denis@mail.ru>
Co-authored-by: blackadder <scope.denis@mail.ru>
src/datautils.py
Outdated
| @@ -220,6 +237,8 @@ def get_loaders(name, nsamples=128, seed=0, seqlen=2048, eval_mode=False, model_ | |||
|
|
|||
| if name.lower() == "wikitext2": | |||
| data = get_wikitext2(nsamples, seqlen, tokenizer, eval_mode=eval_mode) | |||
| elif name.lower() == "pajama": | |||
| data = get_red_pajama(nsamples, seqlen, tokenizer) | |||
There was a problem hiding this comment.
please assert eval_mode here
justheuristic
approved these changes
Jan 12, 2024
Co-authored-by: blackadder <scope.denis@mail.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pajama data generation from togethercomputer/RedPajama-Data-1T…