Skip to content

Create sim_if and test submodules#582

Merged
eine merged 5 commits into
VUnit:masterfrom
eine:sim-if
Nov 14, 2019
Merged

Create sim_if and test submodules#582
eine merged 5 commits into
VUnit:masterfrom
eine:sim-if

Conversation

@eine

@eine eine commented Nov 3, 2019

Copy link
Copy Markdown
Collaborator

Following the same approach as with ui.py, in this PR:

  • A vunit.sim_if submodule is created.
  • Submodule test is renamed to tests.
  • A new submodule names test is created, and all the vunit/test_*.py sources are moved there.
  • vunit.ui.vunit is merged into vunit/ui/__init__.py and unused imports are removed.

@eine eine requested review from LarsAsplund and kraigher November 3, 2019 09:28
@kraigher

Copy link
Copy Markdown
Collaborator

I am basically ok with this as it makes the structure better. Regarding test vs tests I think tests should really be outside the vunit folder. Moving it outside also makes it less confusing.

@eine

eine commented Nov 13, 2019

Copy link
Copy Markdown
Collaborator Author

Regarding test vs tests I think tests should really be outside the vunit folder. Moving it outside also makes it less confusing.

Good idea! It is done now. BTW, builtins imported simulator_check from vunit.test.common (which is now tests.common). However, I think that vunit should not depend on tests. Hence, I moved three helper functions from tests.common to vunit.sim_if.common.

@eine eine merged commit ba1ef07 into VUnit:master Nov 14, 2019
@eine eine deleted the sim-if branch November 14, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants