SGaist review

[VSRonin]

Purely from personal taste:

• Missing white spaces in headers and code files
• Methods, variables classifications in class declaration not coherent
• Public/Protected/Private ordering looks strange to me

Overall:

• MessageTypes, why a vector and a map ?
• What about having links to the documentation in the code comments ?
• What about using a helper function to enable/disable widgets in the interface ?

[kshegunov]

Missing white spaces in headers and code files

I need more expanding on that, what white spaces are missing?

Methods, variables classifications in class declaration not coherent

I'm aware of this, and it will be polished out. In the end I suggest we stick to Qt's coding style.

Public/Protected/Private ordering looks strange to me

How?

MessageTypes, why a vector and a map ?

To be able to quickly convert between QString and MessageType. Can be done with a single vector, but that means iterating the whole array on each conversion from string to type.

What about having links to the documentation in the code comments ?

Like qdoc references? Or do you mean direct links?

What about having links to the documentation in the code comments ?

Can be done, currently in the commonlib branch it's done through the signal-slot connections.