Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to node v12 #4171

Merged
merged 8 commits into from
Nov 29, 2019
Merged

upgrade to node v12 #4171

merged 8 commits into from
Nov 29, 2019

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Oct 14, 2019

What this PR does / why we need it:

upgrade to node v12 used for gulp test and corresponding docs.

Which issue(s) this PR fixes

Special notes for your reviewer:

@J-Fields
Copy link
Member

J-Fields commented Nov 9, 2019

node 13 is out at this point - is it worth upgrading straight to that?

@J-Fields J-Fields merged commit f69a331 into master Nov 29, 2019
@jpoon jpoon deleted the docs branch November 30, 2019 06:55
J-Fields added a commit that referenced this pull request Mar 26, 2020
I think this was missed in #4171
This is required for prettier v2 (#4661), because it dropped support for node versions <10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants