Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md after webpack bundling addition #4128

Merged
merged 2 commits into from
Oct 6, 2019

Conversation

hetmankp
Copy link
Contributor

@hetmankp hetmankp commented Oct 3, 2019

With the addition of Webpack bundling (issue #3127, commit 1f80b2d)
the instructions for how to run tests were no longer working.

With the addition of Webpack bundling (issue VSCodeVim#3127, commit 1f80b2d)
the instructions for how to run tests were no longer working.
@hetmankp
Copy link
Contributor Author

hetmankp commented Oct 3, 2019

The comments in this change may need to be modified as they're basically my best guess at the intent.

@jpoon jpoon merged commit 58945cd into VSCodeVim:master Oct 6, 2019
J-Fields pushed a commit that referenced this pull request Oct 27, 2019
With the revert of the webpack build PR (#4217), we also need to revert the documentation change in CONTRIBUTING.md (#4128).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants