Skip to content

Conversation

@fkrisi11
Copy link

@fkrisi11 fkrisi11 commented Jul 8, 2025

No description provided.

fkrisi11 and others added 2 commits July 8, 2025 22:33
- Buffers are now created with 0.001 starting speed, instead of 0.0001, to correct weird rotation inheritance issues
- All buffer systems are now created with a renderer in place, and disabled, with 'Render Mode' set to 'None'
- New menu item for adding Renderer from all selected
- New menu item for removing Renderer from all selected
- Added a missing Undo action
@jellejurre
Copy link
Collaborator

Maybe add a divider and put them in the same menu instead of having to go a fourth submenu deep, and also maybe only show the option to remove the renderer as enabled if a renderer exists, and only show the option to add as enabled if there is a particle system without a renderer

@fkrisi11
Copy link
Author

fkrisi11 commented Jul 8, 2025

Maybe add a divider and put them in the same menu instead of having to go a fourth submenu deep, and also maybe only show the option to remove the renderer as enabled if a renderer exists, and only show the option to add as enabled if there is a particle system without a renderer

Alrighty, the divider is very fair, and I'll add that, so everything can be in the same menu
The remove and add options are always visible, because you can select multiple particle systems, where some might have renderers, but others might not. This way you can still do batch operations

@jellejurre
Copy link
Collaborator

Maybe add a divider and put them in the same menu instead of having to go a fourth submenu deep, and also maybe only show the option to remove the renderer as enabled if a renderer exists, and only show the option to add as enabled if there is a particle system without a renderer

Alrighty, the divider is very fair, and I'll add that, so everything can be in the same menu The remove and add options are always visible, because you can select multiple particle systems, where some might have renderers, but others might not. This way you can still do batch operations

Yes, but if out of all objects you select, none have renderers, having the remove renderer button visisble is silly, same with if you have no particle systems selected. This can be done using a validate function, no?

@jellejurre
Copy link
Collaborator

right now you just do

	[MenuItem("GameObject/Effects/Buffer Particle/Particle System Renderer/Add Renderer", true, 1002)]
	public static bool AddParticleSystemRendererValidate() => SelectionHasParticleSystem();
	[MenuItem("GameObject/Effects/Buffer Particle/Particle System Renderer/Remove Renderer", true, 1003)]
	public static bool RemoveParticleSystemRendererValidate() => SelectionHasParticleSystem();

but those should also check fi there is something to add or remove

- New category added for renderer management
- Spaced out menu item validation better in the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants