Fix for security issue #3168 #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schandrika looks like there are a couple of failures. The utils looks like a AMQP timeout. Like the rmq server stopped quicker than we would like. However, the auth seems to be a genuine error. https://github.com/VOLTTRON/volttron/actions/runs/8665217491/job/23763385735#step:4:2167 |
|
@craig8 The auth test pass for me locally. The one failing test in auth here, does depend on gevent.sleep(4) so could be a timing issue. |
craig8
previously approved these changes
Apr 16, 2024
craig8
approved these changes
Apr 18, 2024
craig8
added a commit
that referenced
this pull request
May 8, 2024
* Update readthedocs requirements.txt * Update conf.py * Update requirements_demo.txt Add missing pandas requirement for demo * work around for issue #3154 * Fix for security issue #3168 (#3169) * Fix for security issue #3168 * handling clean up errors in test * testing group commands in different test module * moved group and role test to different module * moved group and role test to different module * Added a cache for agent names since platform start * Fixes process overload from file events * fixed issue with variable definition. * Remove PersistentDict from web-user.json file. * Update admin_endpoints.py Handle behavior of removing PersistentDict * Update version to 9.0.1 --------- Co-authored-by: Chandrika Sivaramakrishnan <chandrika@pnnl.gov> Co-authored-by: Chandrika <schandrika@users.noreply.github.com> Co-authored-by: Andrew Rodgers <andrew@aceiotsolutions.com>
craig8
added a commit
that referenced
this pull request
May 10, 2024
* Update readthedocs requirements.txt * Update conf.py * Update requirements_demo.txt Add missing pandas requirement for demo * work around for issue #3154 * Fix for security issue #3168 (#3169) * Fix for security issue #3168 * handling clean up errors in test * testing group commands in different test module * moved group and role test to different module * moved group and role test to different module * Added a cache for agent names since platform start * Fixes process overload from file events * fixed issue with variable definition. * Remove PersistentDict from web-user.json file. * Update admin_endpoints.py Handle behavior of removing PersistentDict * Update version to 9.0.1 --------- Co-authored-by: Chandrika Sivaramakrishnan <chandrika@pnnl.gov> Co-authored-by: Chandrika <schandrika@users.noreply.github.com> Co-authored-by: Andrew Rodgers <andrew@aceiotsolutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and test case for issue #3168