Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: .envのデフォルトエンジン情報を読み出す部分を共通化する #2334

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

Hiroshiba
Copy link
Member

内容

.envのデフォルトエンジン情報を取得している部分がいくつかあるので、共通化することで簡単なリファクタリングを行います。

その他

↑のプルリクエスト内でやった点を切り出した感じです

@Hiroshiba Hiroshiba requested a review from a team as a code owner October 29, 2024 12:57
Copy link
Member Author

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たぶん大丈夫だと思うのでテストが通り次第マージします!

@Hiroshiba Hiroshiba merged commit e1304cc into VOICEVOX:main Oct 30, 2024
8 checks passed
@Hiroshiba Hiroshiba deleted the loadEnvEngineInfosに切り出し branch October 30, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant