fix: ソロ全解除をして再生すると、全解除前のように聞こえるバグの修正 #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
拍子はレンダリングに影響しないので、 |
|
あっなるほどです！！！要らなそう！！ 逆にCOMMANDじゃない |
|
多分大丈夫だと思うのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の修正プルリクエストです。
ついでに全singing.tsのactionを検査して、RENDERが必要そうなやつを点検してみました。
TIME_SIGNATURE周りでRENDERが呼ばれてないやつはいくつかあったんですか、これ多分いりますよね･･･？ということでついでに入れときました。
（
COMMAND_の方にだけRENDERがなかった）関連 Issue
close #2194
その他
点検してた感じ、多分これ使わないだろうなっていうactionがいっぱいありました。
コマンド以外ありえないコマンドじゃない関数とか。
呼び間違いがいつか起こりそうだ、消してもいいかもしれない。