Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: RELOAD_URLで飛ばすページをabout:blankにする #2121

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Change: RELOAD_URLで飛ばすページをabout:blankにする #2121

merged 2 commits into from
Jun 25, 2024

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Jun 15, 2024 •
edited
Loading

内容

RELOAD_URLで飛ばすページをabout:blankにします。

関連 Issue

（なし）

スクリーンショット・動画など

文脈：こんな感じのエラーがでて再起動しなかったことがあるので
image

その他

（なし）

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner June 15, 2024 13:00
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team June 15, 2024 13:00
@sevenc-nanashi sevenc-nanashi changed the title Change: win.reload()を使う Change: RELOAD_URLで飛ばすページをabout:blankにする Jun 15, 2024
Hiroshiba
Hiroshiba approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

実際にvvppインストール時の再読み込みとかを試してみて、ちゃんと動いてそうなことを確認しました！

↓PRのバージョンの様子

Capture_20240626015657.mp4

↓mainブランチ d2275f9 の様子

Capture_20240626020104.mp4

@Hiroshiba Hiroshiba merged commit 5eb01a9 into VOICEVOX:main Jun 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevenc-nanashi @Hiroshiba