"clone-deep"を組み込みのstructuredCloneに置き換える
#2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
nix6839
force-pushed
the
replace-clone-deep-dep
branch
from
9887092
to
1f02ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
以下の投稿を参考にすると、clone-deepとstructuredCloneの動作は__proto__を除けば、structuredCloneの方が優れているか同等であることが分かります。
コードを確認したところ、__proto__に関連するコードがなかったため、clone-deepをstructuredCloneに置き換えることができると判断しました。
Which is the best method for deep cloning in Javascript? Are they all bad? | by Tiago Bértolo | Medium