-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
起動時にプロジェクトファイルを読み込む場合に行うエンコード処理の漏れを修正 #1972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです。
が、そもそもこれの原因はURLクエリ作成を手動でやってるからな気がします:
async function loadUrl(obj: {
isMultiEngineOffMode?: boolean;
projectFilePath?: string;
}) {
const fragment =
`?isMultiEngineOffMode=${obj?.isMultiEngineOffMode ?? false}` +
`&projectFilePath=${obj?.projectFilePath ?? ""}`;
return win.loadURL(`${firstUrl}${fragment}`);
}
これをURLSearchParamsで書き換えるのが正しい解決かも?
それはそうですね. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
実際にprojectFilePath
に#
付きプロジェクトファイルを与えてみて大丈夫なことを確認しました!
プルリクエストありがとうございます、もしよければまた、ぜひ・・・!!
内容
encodeURIComponentを使うようにしました.#=+&/などがエンコードされるようになります.
関連 Issue
close #1970
スクリーンショット・動画など
その他