Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: フォントを改善 #1103

Merged

Conversation

sevenc-nanashi
Copy link
Member

内容

フォントを改善します。

関連 Issue

(なし)

スクリーンショット・動画など

image

その他

フォントをGit LFSで管理するのも有りかも…?

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner January 13, 2023 10:37
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team January 13, 2023 10:37
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいですね!!!

このフォントの作り方を雑なメモで良いので残していただいても良いでしょうか🙇‍♂️
READMEでもdocsのなかの適当な場所とかにでも…!

.gitattributes Outdated Show resolved Hide resolved
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
@Hiroshiba
Copy link
Member

フォントをGit LFSで管理するのも有りかも…?

実はGit LFSには総ダウンロード容量などに制限があってめちゃくちゃ使いづらいんですよね・・・。

@sevenc-nanashi
Copy link
Member Author

なるほど、となるとしない方が良さそう。

@sevenc-nanashi
Copy link
Member Author

作り方のmdを書いてみましたー。

src/fonts/.gitattributes Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ドキュメントもとてもわかりやすかったです、ありがとうございます!!
LFS入ってそうなとこだけ確認&修正頂ければ!

@sevenc-nanashi
Copy link
Member Author

Revertしました。

.gitattributes Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

これvoicevox-blogの方にも入れられると最高だなと思いました!

問題ないと思うのでマージします!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants