Repository navigation
feat(pelorus): vendor interop ABI + sync guard + conformance gate (ADR-1113) - #925
Merged
Merged
Conversation
…gate (ADR-1113) Plan A1+A2+A3: vendor interop.c/.h (+deband_params.c, version.c) from VMAFx/pelorus@835e097 as a pinned read-only mirror (DO-NOT-EDIT banner; append-only ABI) + scripts/sync-pelorus-interop.sh drift guard + the shared 7-vector conformance gate (7/7 pass). Vendored files excluded from clang-format + touched-file lint (must stay byte-identical). vmafx side stays Vulkan-free. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendors the Pelorus
interop.hside-data ABI into vmafx as a pinned read-only mirror + a sync-drift guard + the shared 7-vector conformance gate — the foundation (plan workstreams A1+A2+A3) for the bidirectional pelorus↔vmafx integration's data plane. The vmafx side stays Vulkan-free (it only parses a CPU side-data blob). Companion to the merged pelorus AVOption-contract PR (pelorus #4).Type
feat— new feature (integration foundation)Checklist
make format && make lintgreen locally (vendored files excluded from clang-format/clang-tidy/cppcheck — they must stay byte-identical to pelorus; same idiom as vendored libsvm/pdjson).meson test -C core/build-cpu test_pelorus_interop(the shared 7 conformance vectors: roundtrip, forward_compat, abi_major_mismatch, foreign_buffer, header_only, truncation, deband_params) → 7/7.Copyright 2026 Lusoris/ BSD+Patent header + a DO-NOT-EDIT banner; new wrapper/test/docs use the Lusoris header.docs/adr/_index_fragments/1113-vendor-pelorus-interop-abi.md+_order.txt).Bug-status hygiene
docs/state.mdupdated — added a Recently-closed row for the integration-foundation.Netflix golden-data gate
Deep-dive deliverables
docs/research/1101-vendor-pelorus-interop-abi.md.docs/adr/1113-vendor-pelorus-interop-abi.md## Alternatives considered(vendor-copy+sync-guard vs git-submodule vs meson-subproject vs hand-reimplement).AGENTS.mdinvariant note — the vendored ABI is append-only, single-source-of-truth = pelorus; never hand-edit (in the docs + banner).changelog.d/added/1113-vendor-pelorus-interop-abi.md.docs/rebase-notes.mdentry.Reproducer
Known follow-ups
vf_libvmafparses the blob for perceptual weighting) + the control-plane autotune are the next integration PRs; this PR is the ABI handshake they build on.