Repository navigation
fix(ai): restore ensemble registry license metadata + defer prod flip to one-shot retrain (ADR-1105) - #902
Merged
Conversation
… to one-shot retrain (ADR-1105) PR #865 regenerated the five fr_regressor_v2_ensemble_v1_seed{0..4} ONNX files in --smoke mode to fix a codec_vocab 14->6 input-dim mismatch, but two side effects regressed the registry: 1. license / license_url / sigstore_bundle were dropped from the five rows, breaking test_every_entry_has_license_metadata. Restored here (every entry must carry license metadata, smoke or not). 2. The rows now ship smoke weights while ADR-0321's test asserts production (smoke=false). The ADR-0321 production weights were LOSO-validated at codec_vocab=14; the trim to 6 made them stale, and real production weights at width 6 require re-running export_ensemble_v2_seeds.py -- part of the locked one-shot post-RC retrain (ensemble is in scope; piecemeal retrain is explicitly out). For the RC: keep smoke=true (matches the shipped weights honestly), and mark test_fr_regressor_v2_ensemble_seed_rows_are_production xfail(strict=True) with an ADR-1105 reason. strict=True flips it back to a hard failure the moment the one-shot retrain lands real weights, forcing removal of the marker. No Netflix golden-data assertion modified (model_registry_schema_test.py is fork-local). - ADR-1105 (Accepted) + README index row - docs/state.md: T-ENSEMBLE-V2-PROD-FLIP-DEFERRED row - docs/ai/models/fr_regressor_v2_probabilistic.md: status block corrected - changelog.d/fixed fragment Local: python3 -m pytest python/test/model_registry_schema_test.py -> 10 passed, 1 xfailed; validate_model_registry.py -> OK 26 entries. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
12 of 26 tasks
11 of 27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RC-polish: fixes the
model/tiny/registry.jsondefects that PR #865(
8b7ae731a) introduced when it regenerated the fivefr_regressor_v2_ensemble_v1_seed{0..4}ONNX files in--smokemode torepair a
codec_vocab14→6 input-dim mismatch.license/license_url/sigstore_bundlefrom the five rows,breaking
test_every_entry_has_license_metadata(every entry mustcarry license metadata, smoke or not). Restored.
rows now ship smoke weights, but ADR-0321's
test_fr_regressor_v2_ensemble_seed_rows_are_productionassertssmoke: false. The ADR-0321 production weights were LOSO-validated atcodec_vocab=14; the trim to 6 made them stale, and real productionweights at width 6 require re-running
export_ensemble_v2_seeds.py—part of the locked one-shot post-RC retrain (ensemble is in scope;
piecemeal retraining is explicitly out of scope). For the RC we keep
smoke: true(truthful about the shipped weights) and mark theproduction test
xfail(strict=True).strict=Trueflips it back to ahard failure the moment the retrain lands real weights, forcing
removal of the marker.
No Netflix golden-data assertion modified —
model_registry_schema_test.pyis fork-local (CLAUDE.md §8 untouched).
Reproducer / smoke test
Deliverables (ADR-0108)
## Alternatives considered(retrain-now / revert-ONNX / leave-red / delete-sidecars all evaluated).changelog.d/fixed/ensemble-v2-registry-license-restore-smoke-honest.md.Docs / state
docs/ai/models/fr_regressor_v2_probabilistic.mdstatus block corrected (production → smoke-placeholder-pending-retrain).T-ENSEMBLE-V2-PROD-FLIP-DEFERREDrow added to Open bugs.