Repository navigation
fix(rc): implement picture_v2 API + fix ai/scripts stub exit codes - #886
Merged
Merged
Conversation
ADR-0928 cycle N+1: all five VmafPicture v2 entry points implemented in core/src/picture_v2.c (vmaf_picture2_alloc, vmaf_picture2_unref, vmaf_picture_v1_to_v2, vmaf_picture_v2_to_v1, vmaf_backend_handle_name). Header installed via meson install_headers; 10-case unit test added (test_picture_v2, suite: fast). Previously the header was a design-only stub with unlinked symbols. Fixed 13 ai/scripts stubs that exited with code 0 (success) despite being unimplemented, misleading CI and callers. All now exit with code 1 and print a guidance message to stderr. 89/89 fast tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lusoris
force-pushed
the
rc/scaffold-stub-completion
branch
from
June 12, 2026 22:06
88ecdb9 to
697a276
Compare
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/src/picture_v2.care now live inlibvmaf.so. Previously the header was design-only and all symbols were unlinked. Header now installed viameson install_headers. 10-case unit test added to the fast suite (test_picture_v2).-ENOSYSpatterns (HIP/Metal/DNN disabled-build stubs, MCP scaffold) are correct conditional-build behavior, not misleading silences.Scaffold inventory
picture_v2.h— 5 unlinked entry pointspicture_v2.c, header installedai/scripts/*.pysys.exit(0)stubssys.exit(1)-ENOSYSstubsTest plan
meson test -C <build> --suite=fast→ 89/89 pass (up from 88)test_picture_v2covers:vmaf_backend_handle_nameknown + OOB,vmaf_picture2_alloc/unrefhappy + null paths,vmaf_picture_v1_to_v2/v2_to_v1happy + null paths, round-tripDeliverables checklist
core/include/libvmaf/AGENTS.mdpicture_v2 invariant notemeson test -C build --suite=fast(test_picture_v2 at index 17)changelog.d/fixed/rc-scaffold-stub-completion.mddocs/rebase-notes.md§ rc/scaffold-stub-completion🤖 Generated with Claude Code