Repository navigation
fix(compat): remove stale ATOM_FEATURES ansnr/anpsnr mappings (Research-0733 Phase 2) - #88
Merged
Merged
Conversation
lusoris
enabled auto-merge (squash)
May 28, 2026 21:54
…ch-0733 Phase 2) Remove "ansnr" and "anpsnr" from VmafFeatureExtractor.ATOM_FEATURES, drop ATOM_FEATURES_TO_VMAFEXEC_KEY_DICT overrides for both, remove float_ansnr from the VmafFeatureExtractor feature list. Completes ansnr cleanup started in #38 / ADR-0720. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lusoris
force-pushed
the
chore/atom-features-ansnr-cleanup-20260528
branch
from
May 28, 2026 22:50
ef8cb2e to
faa959e
Compare
lusoris
added a commit
that referenced
this pull request
Oct 7, 2026
…report CSV with _wfsopen (ADR-1113) (#2424) * refactor(interop): re-vendor Pelorus at the commit that opens the qp-report CSV with _wfsopen (ADR-1113) VMAFx/pelorus #89 (fixing #88) moves open_utf8() from the deprecated _wfopen() to _wfsopen(..., _SH_DENYNO), the local edit the MSVC zero-warnings series carried in core/src/interop/pelorus_qp_report_csv.c. PELORUS_VENDOR_SHA moves to 4aae30711c65 and --update re-renders the ten vendored files; the mirror is byte-identical to pelorus again apart from the banner and the include rewrite, and the drift check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"ansnr"and"anpsnr"fromVmafFeatureExtractor.ATOM_FEATURES— both mapped tofloat_ansnr/float_anpsnrwhich were deleted by PR feat(core): drop legacy ansnr feature (pre-VMAF, never Netflix-adopted) #38 from CPU, CUDA, SYCL, HIP, and Metal backendsATOM_FEATURES_TO_VMAFEXEC_KEY_DICT["ansnr"]and["anpsnr"]overrides in bothVmafFeatureExtractorandVmafIntegerFeatureExtractor"float_ansnr"from thefeatures = [...]lists in both_generate_result()methodsAnsnrFeatureExtractorclass (Netflix golden tests inpython/test/feature_extractor_test.pyimport it)Test plan
meson setup /tmp/bc core -Denable_cuda=false -Denable_sycl=false && ninja -C /tmp/bc && meson test -C /tmp/bc --suite=fast→ 49/49 OKpython3 -c "import ast; ast.parse(open('compat/python-vmaf/core/feature_extractor.py').read()); print('OK')"→ OKgrep -n '"ansnr"' compat/python-vmaf/core/feature_extractor.py→ onlyAnsnrFeatureExtractorlines remainDeep-dive deliverables (ADR-0108)
changelog.d/fixed/atom-features-stale-ansnr.mddocs/rebase-notes.mdentry — upstream may re-add ansnr; resist🤖 Generated with Claude Code