Repository navigation
fix: rounds 1-5 medium/low residual cleanup (26 files, 26 fixes) - #863
Merged
Merged
Conversation
…iles (rounds 1-5 medium/low residual)
Dead-code removals (4):
- Remove unused threaded_read_pictures() from libvmaf.c (superseded by _batch variant).
- Remove dead hsum_epi32() from integer_ssim_avx2.c (never called).
- Remove dead load_module_fn() from integer_adm_hip.c (never called).
- Remove dead init_index_cuda() from integer_adm_cuda.c (never called).
Error-path return-value discipline (3):
- ciede.c: add (void) casts on vmaf_picture_unref() calls in close().
- integer_motion_v2.c: add (void) casts on vmaf_feature_collector_append_with_dict()
calls at motion2/motion3 post-processing loop (lines were bare, unchecked).
NOLINT ADR-0278 citation closure (19 files):
- Add inline ADR-0278 citation to every bare misc-use-internal-linkage NOLINT
in feature extractors (float_ssim, ms_ssim, float_ms_ssim, ssim, integer_ssim,
integer_adm, integer_motion_v2, cuda/ssim_cuda, hip/{ciede,float_moment,
float_motion,float_psnr,float_ssim,float_vif,integer_adm,integer_motion_v2,
integer_ms_ssim,integer_psnr,integer_psnr_hvs,integer_ssim}).
- dnn_api.c / ort_backend.c: add ADR-0040 citation to
readability-non-const-parameter NOLINTs (stub signatures must match ORT header).
All 87/87 fast tests pass. pre-commit clean.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup pass targeting medium/low severity items from rounds 1-5 audits that were deferred from PRs #857/#858/#859.
Dead code removed (4 items):
threaded_read_pictures()inlibvmaf.c— superseded by_batchvariant, never calledhsum_epi32()ininteger_ssim_avx2.c— helper defined but never invokedload_module_fn()ininteger_adm_hip.c— HIP module loading done differently, never calledinit_index_cuda()ininteger_adm_cuda.c— CUDA index helper defined but never invokedError-path return-value discipline (3 items):
ciede.cclose(): add(void)casts on uncheckedvmaf_picture_unref()callsinteger_motion_v2.cpost-processing loop: add(void)casts on uncheckedvmaf_feature_collector_append_with_dict()at motion2 and motion3 frame stampNOLINT ADR citation closure (19 files / ~19 items):
NOLINTNEXTLINE(misc-use-internal-linkage)in feature extractorvmaf_fex_*structs now cite ADR-0278 (cross-TU registry pattern) per CLAUDE.md §12 r12dnn_api.candort_backend.cstubreadability-non-const-parameterNOLINTs now cite ADR-0040 (stub signatures must match ORT header)Test plan
meson test --suite=fast87/87 PASSpre-commit run --files <changed>all hooks PASSscripts/ci/check-copyright.shPASS on all changed filesDeep-dive deliverables (ADR-0108)
meson test -C build-wt --suite=fast— 87/87state.md
No bugs closed/opened by this PR (cleanup only).
🤖 Generated with Claude Code