Repository navigation
chore(bundle): drain 8 rebased DRAFT PRs (docs + helm + tests-coverage) - #845
Merged
Merged
Conversation
…(ADR-1096) 214 internal headers had no Doxygen coverage; only 26 had any @brief/@PARAM annotation. Adds @brief, @PARAM[in/out], and @return comments to the ten highest-traffic headers: framesync.h thread_pool.h picture_pool.h predict.h fex_ctx_vector.h ref.h mem.h log.h opt.h dict.h Purely additive — no logic, no ABI, no public-header changes. IDE hover-docs and doxygen -q now populate for all covered APIs. ADR-1096 documents the coverage decision and follow-up scope. AGENTS.md invariant added: update Doxygen blocks when signatures change. no digest needed: trivial doc-only addition no alternatives: only-one-way fix (add the comments) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ic C-API functions Every VMAF_EXPORT function in core/include/libvmaf/ now carries a complete Doxygen contract: @PARAM, @return, and @Thread-safety. Previously libvmaf_cuda.h (5 functions), libvmaf_sycl.h (20), dnn.h (9), picture_v2.h (5), and model.h (vmaf_model_version_next) were missing @Thread-safety entirely; picture_v2.h stubs were also missing @param/@return. VmafPoolingMethod in libvmaf.h lacked a @brief enum-level description. The thread-safety contract is uniform: GPU backend setup functions (cuda/sycl/ hip/metal state init/import/free, preallocate, fetch) are not thread-safe — one handle per driver thread. Pure query functions (vmaf_dnn_available, vmaf_sycl_list_devices, vmaf_dnn_verify_signature, vmaf_backend_handle_name, vmaf_model_version_next) are marked safe from any thread. No C source files, build files, or ABI-visible signatures changed — Doxygen comment additions only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add three missing Recently-closed rows that were absent from state.md: - T-GPU-POOL-UAF-OOM-ASAN-UBSAN-GAP-2026-06-06: PRs #767 + #770 added three huge-alloc tests to ASan/UBSan/TSan exclusion lists in both sanitizers.yml and tests-and-quality-gates.yml; CI SIGABRT spurious failures resolved. - T-HIP-MOTION-DEBUG-BOOL-SYCL-GRAPH-DANGLING-2026-06-06: PR #768 fixed HIP motion test passing "1" for a VMAF_OPT_TYPE_BOOL option (should be "true") and a SYCL graph dangling-priv SIGSEGV when a VmafSyclState is shared across two sequential VmafContext instances. - T-MOTION-FIVE-FRAME-WINDOW-PYTHON-SKIP-2026-06-06: PR #771 added @unittest.skip decorators to 9 Python test methods that set motion_five_frame_window=True, which returns -ENOTSUP from C per ADR-0337 pending prev_prev_ref plumbing. PRs #765 (T-PREV-REF-BATCH-REFCOUNT-LEAK), #766 (T-MCP-SCORE-POOLED-EAGAIN), and #769 (T-PIC-PREALLOC-ASAN-LEAK) were already tracked. PR #770 adds no new bug row (CI wiring fix only, no new defect opened/closed). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
State.md updates promised by squash commits for PRs #723, #725, #729, and #743 were lost (the pre-squash branch commits carried the changes but the squash commits did not include state.md in their diffs). Changes: - Move T-JSON-MODEL-SLOPES-FEATURE-CAP-OOB-2026-05-30 from Open to Recently closed — fixed by PR #743 / ADR-0887 (vmaf_model_destroy heap-buffer-overflow via fuzz_json_model nightly harness). - Add T-FFMPEG-PATCHES-SCORE-FMT-GAP-2026-06-06 to Recently closed — PR #723 / ADR-1064 wired score_fmt AVOption on all four FFmpeg vmaf filters; PR #740 fixed patch hunk counts. - Add T-VENDORED-CJSON-PDJSON-SECURITY-2026-06-06 to Recently closed — PR #725 / ADR-1061 fixed five pdjson/cJSON security and correctness bugs (depth guard never compiled, size overflow x2, banned sprintf/ strcpy at 12 sites, cJSON_GetArraySize int wrap). - Add T-GO-STATICCHECK-R10-TIMER-BODY-2026-06-06 to Recently closed — PR #729 / ADR-1065 fixed Go timer leak (time.After in poll loop), missing body size cap on vmafx-controller, and missing ReadTimeout on both HTTP servers. - Add second-pass _Updated: header summarising the PRs #712–#747 batch. no rebase impact: state.md only, no code or API surface changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Audit found the following docs/**.md files present on disk but absent from both the mkdocs.yml nav and any inbound cross-reference: - docs/ai/sidecar-online-training.md (k8s Phase 4b sidecar trainer) - docs/server/auth.md (JWT auth gateway for vmafx-controller) - docs/server/operator.md (kubebuilder Kubernetes operator) - docs/server/rest.md (vmafx-server REST/OpenAPI surface) - docs/development/ebpf-fuse-bypass.md (rclone FUSE eBPF bypass) - docs/development/perf-claims-2026-05-10.md (May 2026 perf claims log) - docs/sync-upstream/2026-05-02-sync-report.md (upstream sync report) - docs/sync-upstream/2026-05-03-sync-report.md (upstream sync report) - docs/upstream-ports/1b08bb4d-needs-manual-port.md (manual port note) Also excludes docs/changelog.d/** from the mkdocs build — one changelog fragment (cpp23-wave3.md) was placed under docs/changelog.d/ instead of the repo-root changelog.d/; the fragment is referenced by the ADR index but is not a standalone page and should not be rendered by mkdocs. No code changes. No ADR required (nav-only housekeeping). no rebase impact: docs/mkdocs.yml nav entries only Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ricsPort, extraPorts schema (ADR-1074) Four gaps where values.yaml / values.schema.json diverged from template usage: 1. nameOverride/fullnameOverride: read by _helpers.tpl but absent from both values.yaml and the root additionalProperties:false schema; any user supplying --set nameOverride=foo received an immediate helm-lint failure. Added as string keys to both files. 2. statefulSet.statePVCSize: statefulset.yaml hardcoded `storage: 1Gi` for the per-replica MCP-state PVC. Exposed as statefulSet.statePVCSize (default 1Gi) and wired into the volumeClaimTemplates storage field. 3. node.metricsPort: port 9090 appeared hardcoded in three template locations (node Deployment containerPort, node-metrics Service port, NetworkPolicy allow rule). Exposed as node.metricsPort (default 9090) and unified. 4. service.extraPorts items schema: bare `"type": "array"` with no items definition accepted malformed port objects silently. Added items schema with required [name, port] and protocol enum. All defaults preserve existing rendered output byte-for-byte. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…alyze_knob_sweep helpers (round 3)
The existing test_calibrate_phase_f_recipes.py covers only the main()
invocation (run-provenance smoke). The existing test_knob_sweep_analysis.py
covers pareto_frontier, stratify, and detect_recipe_regressions via a
20-row synthetic fixture.
This commit adds coverage for the remaining pure helper functions:
* test_calibrate_phase_f_recipes_unit.py (50 tests):
- mos_to_vmaf_proxy: clamping, boundary MOS values, string coercion
- saliency_benefit_to_intensity: threshold boundaries for all three labels
- _iter_corpus_rows: valid rows, blank-line skip, malformed-JSON skip,
missing-field skip, optional duration_s default
- _ugc_target_vmaf_offset: empty/small corpus, symmetric distribution,
heavy-tail sign, clamp bounds, rounding
- _ugc_tight_interval_width: empty corpus fallback, uniform/wide
distributions, floor/cap enforcement, rounding
- _resolution_dominance: empty, single-resolution, split, dominant bucket,
portrait-vs-landscape distinction
- _ugc_saliency_benefit_fraction: fallback, no-qualify, all-qualify,
half-qualify, high-MOS exclusion, square-aspect treatment
- calibrate() integration: all four recipe classes, UGC/proxy provenance
tags, required recipe keys, saliency label validity
* test_analyze_knob_sweep_unit.py (29 tests):
- _stable_knob_repr: empty dict, single entry, alphabetical sort, non-Mapping
input, numeric values, insertion-order invariance
- _slug: alphanumeric passthrough, hyphen/underscore preserved, space/slash
replacement, empty-string fallback, all-special-chars
- _closest_bare_at_bitrate: no-bare-rows, within tolerance, outside
tolerance, picks closest, exact match, zero-tolerance
- write_slice_csv: filename pattern, header row, data rows, slug-safe names,
auto-creates output directory
- write_summary_md: file creation, slice count, no-regression message,
regression table, auto-creates output directory
All 79 tests run without GPU, corpus, or model downloads (<100 ms total).
no rebase impact: test-only addition; no existing golden assertion modified.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…per ADR-0278
Replace all //nolint:errcheck suppression comments in grpc_server_handler_test.go
with explicit-discard patterns (_ = x.Close() / defer func() { _ = x.Close() }()).
Also remove duplicate TestGRPCScore_ScorerError function (the earlier copy was
accidentally left in; keep the one with the fuller doc comment at the bottom of
the file). Remove duplicate TestRunHTTP_BadAddress from main_extra_test.go.
Fix unchecked ln.Close() and conn.Close() in TestRunHTTPGracefulShutdown.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lusoris
marked this pull request as ready for review
June 8, 2026 00:51
This was referenced Jun 8, 2026
Closed
lusoris
added a commit
that referenced
this pull request
Jun 8, 2026
…846) * fix(ai): extend _ugc_tight_interval_width guard to single-row corpora statistics.quantiles() requires at least 2 data points and raises StatisticsError when called with a 1-element list. The existing guard (`if not rows`) only covered the empty-list case; a single-element corpus passed through and crashed. Extend the guard to `if len(rows) < 2` so both zero-row and one-row inputs return the 3.0 fallback. Exposed by test_single_row_falls_back in ai/tests/test_calibrate_phase_f_recipes_unit.py (shipped in #845). The production bug predated #845 (present at f21d9bc). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(observability): add branch-coverage fill-ins for pkg/observability Raise statement coverage from 89.1 % to 91.3 % by targeting the specific uncovered branches identified via `go test -coverprofile`: - WaitForShutdown SIGTERM signal-delivery path (was only context-cancel path tested). - InitOTel with OTEL_TRACES_SAMPLER_ARG in [0.0, 1.0]: covers the `sampleRatio = parsed` assignment branch (0.0, 0.5, 1.0 boundary cases). - SetControllerSources half-nil cases: q=non-nil+r=nil registers only queue gauges; q=nil+r=non-nil registers only the node gauge. - Prometheus registry isolation: two independent Metrics instances on separate registries do not bleed counter increments into each other (ADR-1014 isolation property). - OTel attribute key strings locked to ADR-0782 schema values to catch any accidental rename before it reaches OTLP consumers. ADR-0108 deliverables: - no digest needed: trivial (pure test coverage fill-in) - no alternatives: only-one-way fix (add the missing test branches) - AGENTS.md: invariant notes added for SIGTERM test, half-nil cases, and attr-key schema lock - changelog.d/added/observability-coverage-gaps.md - docs/rebase-notes.md: no rebase impact (test + doc only) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Lusoris <lusoris@pm.me> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drains 8 rebased DRAFT PRs into one squash-merged commit to avoid 8 separate master-CI cycles. Each was rebased onto current master earlier in the session and verified individually.
Bundled PRs:
Test plan
meson test -C build-bundle-verify --suite=fast84/84 PASSgit grep '^<<<<<<'empty)Deep-dive deliverables (ADR-0108)
meson test -C build-bundle-verify --suite=fast84/84 PASSstate.md touch