Repository navigation
Conversation
Following the ADR-0700 repo-layout rename (libvmaf/ → core/), five CI workflow files still referenced the old source-directory path. This caused CodeQL (Python/C++), Docker, FFmpeg-integration, nightly clang-tidy, and supply-chain builds to fail, blocking all merges via the Required Checks Aggregator. Changes: - docker-image.yml, ffmpeg-integration.yml: path filters libvmaf/** → core/** - ffmpeg-integration.yml: meson setup sourcedir libvmaf → core (×3) - supply-chain.yml: meson setup sourcedir libvmaf → core - nightly.yml: cd libvmaf → cd core; find libvmaf/src libvmaf/tools → core/src core/tools - tests-and-quality-gates.yml, libvmaf-build-matrix.yml: stale comments updated - security-scans.yml: replace gitleaks-action@v2.3.9 (requires GITLEAKS_LICENSE on org repos) with direct gitleaks CLI binary install (Apache-2.0 CLI, no license required); keeps SARIF upload - Repo: vulnerability alerts + dependency graph enabled via GitHub API no user-discoverable surface change — CI infra repair no digest needed: post-rename path fix, mechanical equivalent no decision matrix needed: pure path-rename fix following ADR-0700 no rebase-sensitive invariants Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…p32-fallback PR #642 (ADR-1032) changed vmaf_dnn_session_open to silently fall back to fp32 when the .int8.onnx sibling is missing, but the test was not updated to match. The test was asserting rc < 0 (hard error) while the new policy returns rc == 0 (degraded-but-working fallback). Rename test_session_open_int8_missing_returns_error → test_session_open_int8_missing_falls_back_to_fp32 and flip the assertions to verify the fp32 fallback succeeds and produces a usable session. Fixes CI failure: libvmaf:dnn / test_dnn_session_api FAIL (exit status 1). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing in favor of rebased version (conflict resolved by cherry-pick onto current master). |
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_session_open_int8_missing_returns_errorwas assertingrc < 0when.int8.onnxis absent, but PR fix(libvmaf,dnn): vmaf_init double-init guard + vmaf_close pointer-zero + DNN fallback path #642 (ADR-1032) intentionally changedvmaf_dnn_session_opento fall back to the fp32 baseline instead of returning an error.libvmaf:dnn / test_dnn_session_apito fail in CI.test_session_open_int8_missing_falls_back_to_fp32and flip the assertions to verify the fp32 fallback path:rc == 0, session pointer populated, session usable.Root cause
Commit
1958126bb(PR #642, ADR-1032) changed the behavior incore/src/dnn/dnn_api.c(lines 108–119): on missing.int8.onnx,rcis now set to0and execution falls through tovmaf_ort_openwith the original fp32 path. The test file was not updated in that PR.Reproducer
Checklist
changelog.d/fragment: not required for test-only fixes with no user-visible delta (ADR-0108 §exclusions)docs/state.md: not required — this is a test fix, not a bug open/close against production behavior🤖 Generated with Claude Code