Repository navigation
Conversation
lusoris
marked this pull request as ready for review
May 31, 2026 02:51
lusoris
enabled auto-merge (squash)
May 31, 2026 02:51
auto-merge was automatically disabled
May 31, 2026 02:51
Pull request was closed
lusoris
force-pushed
the
chore/coverage-ratchet-aggressive
branch
from
May 31, 2026 02:51
fdf2179 to
aea2d2b
Compare
lusoris
enabled auto-merge (squash)
May 31, 2026 02:51
Merged
5 of 6 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise the Coverage Gate's absolute floors aggressively and introduce a new
per-PR coverage-delta gate so coverage can no longer decay one PR at a
time between absolute-floor trips. See
ADR-0922
for the full rationale, the alternatives table, and the 30-day grace
window for in-flight PRs.
Floor changes (one-way ratchet)
OVERALL_MINscripts/ci/coverage-check.shCRITICAL_MINscripts/ci/coverage-check.shPER_FILE_MIN["core/src/dnn/ort_backend.c"]scripts/ci/coverage-check.shPER_FILE_MIN["core/src/dnn/dnn_api.c"]scripts/ci/coverage-check.shPER_FILE_MIN["core/src/dnn/tiny_extractor_template.h"]scripts/ci/coverage-check.shscripts/ci/coverage-delta-check.shscripts/ci/coverage-delta-check.shLowering any floor or loosening the delta tolerance requires a new ADR
that explicitly supersedes ADR-0922 and is cited inline at the changed
threshold.
New gate:
scripts/ci/coverage-delta-check.shCompares head vs. merge-base gcovr summaries on
pull_requestevents andfails if:
--max-overall-drop(default0.5pp), OR
more than
--max-file-drop(default 0.5pp).New files have no base row to compare to and are covered by the absolute
floors only. Files not touched by the PR are not scored. Wired into the
existing
coveragejob intests-and-quality-gates.yml; needsactions/checkoutwithfetch-depth: 0sogit merge-basecan resolve.Grace window for in-flight PRs
PRs opened before 2026-05-31 are exempt from the new floors and the
delta gate for 30 days (through 2026-06-30). Reviewers apply the
exemption manually by checking the PR open-date; the exemption
self-disables on 2026-06-30 and the policy becomes uniform thereafter.
Type
ci— tooling / infradocs— ADR + research digest + rebase note + changelog fragmentChecklist
pre-commit run --files <touched>is green locally (shfmt + shellcheck + ADR-0332 worktree guard + ADR-0386 collision + ADR-0105 header check + semgrep all pass).docs/adr/_index_fragments/0922-coverage-ratchet-aggressive.mdand the slug is appended todocs/adr/_index_fragments/_order.txt.Bug-status hygiene (ADR-0165)
Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.Deep-dive deliverables (ADR-0108)
docs/research/0922-coverage-ratchet-aggressive.md(sizing rationale, variance measurements, risk table).docs/adr/0922-coverage-ratchet-aggressive.md§Alternatives considered (6 alternatives evaluated).AGENTS.mdinvariant note — added toAGENTS.md§13 + new "Coverage Gate ratchet (ADR-0922)" section inscripts/ci/AGENTS.md.changelog.d/changed/0922-coverage-ratchet-aggressive.md.docs/rebase-notes.md("ADR-0922 — coverage ratchet + per-PR delta gate — 2026-05-31").Reproducer
scripts/ci/coverage-delta-check.shexercise (PASS + 2 FAIL cases) usinghand-crafted gcovr JSON fixtures:
scripts/ci/coverage-check.shPASS-case smoke:Known follow-ups
coverage-delta-check.shsmoke tests to a tracked test underscripts/ci/tests/once the directory exists.show overall sitting above 65 %.
docs/adr/README.mdregeneration drift (fragments dir on masteris incomplete) is out of scope for this PR; opted to manually append
the ADR-0922 row instead of running the full concat script.
Generated with Claude Code