Repository navigation
fix(deps): move to golusoris v0.13.1 and core v0.10.1 - #2656
Merged
Merged
Conversation
lusoris
force-pushed
the
chore/golusoris-v0.13.0
branch
from
October 9, 2026 09:04
367f7f6 to
0377d19
Compare
* fix(deps): move to golusoris v0.13.1 and core v0.10.1 Moves the Go module from golusoris v0.12.0 and core v0.9.2 to v0.13.1 and v0.10.1, and applies the breaking changes of golusoris#633 that reach VMAFx call sites: - jobs.Register returns an error. backend.RegisterLeaseSweep returns it and the controller stops the River start on it, where River used to panic on a duplicate registration. sweep_test.go covers fresh, nil and uninitialised registries, a nil sweeper and a second registration. - testutil/pg refuses a test image without a digest. storetest.Image and OldestImage are pinned to the index digests of postgres:18.6-alpine and postgres:16.15-alpine; without the pin every Postgres-backed controller test fails at start. - httpx/server treats http.limits.body=0 as the 10 MiB default and adds http.limits.unlimited. The platform definition documents both keys, the env tables are regenerated, and hardening_test.go pins both behaviours on the production graph. No other item of the golusoris v0.13.0 migration guide reaches a package VMAFx imports. v0.13.1 over v0.13.0 is bug fixes in packages VMAFx does not import. Signed-off-by: Lusoris <lusoris@proton.me>
lusoris
force-pushed
the
chore/golusoris-v0.13.0
branch
from
October 9, 2026 09:53
0377d19 to
f231bd1
Compare
This was referenced Oct 9, 2026
lusoris
added a commit
that referenced
this pull request
Oct 9, 2026
…ovate (#2670) * chore(deps): track the store tests' PostgreSQL image digests with Renovate #2656 pins storetest.Image and storetest.OldestImage as postgres:<tag>@sha256:<digest> Go constants, because golusoris testutil/pg refuses an undigested image. No built-in Renovate manager reads a Go string, so neither digest would ever be updated: a full local extraction with the master config never lists storetest.go. A regex custom manager (depNameTemplate postgres) matches both constants; Renovate 44.56.3 extracts them with tag and digest and, for planted older tags, proposes minor, major and digest updates for Image and only 16.x updates for OldestImage, which a package rule holds on its major line. Two fixture tests evaluate the configured patterns. The JavaScript-to-Python named-group conversion three Renovate tests each spelled moves to scripts/lib/renovate_regex.py. Signed-off-by: Lusoris <lusoris@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the Go module to golusoris v0.13.1 and golusoris/core v0.10.1 (from v0.12.0 and v0.9.2) and applies the breaking changes of golusoris #633 that reach VMAFx call sites. Of the packages VMAFx imports, three changed under it:
jobs.Registernow returns an error,testutil/pgrefuses a test image without a digest, andhttp.limits.body=0now keeps the 10 MiB request-body cap instead of removing it. v0.13.1 over v0.13.0 is bug fixes only; none touches a package VMAFx imports.Migrations applied:
jobs.Registerreturnserror:backend.RegisterLeaseSweepreturns it andnewSweepClientstops the River start on it (cmd/vmafx-controller/backend/sweep.go,cmd/vmafx-controller/store_wiring.go, the call inbackend/postgres_test.go). Before, River'sAddWorkerpanicked on a duplicate registration. New tests inbackend/sweep_test.gocover a fresh registry, nil and uninitialised registries, a nil sweeper and a second registration. If the error is swallowed, both negative tests fail.testutil/pgaccepts onlytag@sha256:<digest>images:storetest.Imageandstoretest.OldestImageare pinned to the multi-platform index digests ofpostgres:18.6-alpineandpostgres:16.15-alpine. The registry's tag API anddocker buildx imagetools inspectreturn the same digests. Without the pin, every Postgres-backed test incmd/vmafx-controller,backendandstorefails at start (testutil/pg: validate image: test image must use tag@sha256:...).httpx/server:VMAFX_HTTP_LIMITS_BODY=0now keeps the default cap, andhttp.limits.unlimitedis the explicit opt-out.api/vmafx-platform.tomldocuments both. The generated env tables (docs/usage/env-vars.md,docs/server/{controller,grpc,node}.md) are regenerated, andcmd/vmafx-server/hardening_test.gopins both behaviours on the production graph.Nothing else in the v0.13.0 migration guide (
docs/migrations/v0.13.0.mdin golusoris) reaches VMAFx: it uses none of the auth, cors, llm, webhooks, notify, storage, certmagic, tenancy, idempotency or workflow packages.Type
feat— new featurefix— bug fixperf— performance improvementrefactor— no behavior changedocs— documentation onlytest— test-onlybuild/ci— tooling / infraport— cherry-pick from upstream Netflix/vmafsycl/cuda/simd— backend-specificChecklist
git commit -s; fix a branch withgit rebase --signoff origin/master). See DCO sign-off.make format && make lintis green locally. Not run in full: only Go, TOML and generated Markdown changed. Rangofmt,go vet,go fix -diff,make lint-go(the 5 gosec findings already on master, none new),scripts/codegen/vmafx-api.py --checkand the pre-commit hook set.python3 scripts/ci/run_meson_test.py -- -C build. Not run: no file undercore/changed. The Go suite ran instead (see Reproducer)./cross-backend-diffand the worst ULP is ≤ 2. No SIMD/GPU path touched..c/.cpp/.cu/.h/.hpp, it has the appropriate license header (seeCONTRIBUTING.md). No C/C++ file added; the new Go test file carries the EUPL-1.2 header.!orBREAKING CHANGE:and the migration path is documented below. Not breaking for VMAFx users; see "Breaking changes / migration" for the one changed setting.docs/adr/_index_fragments/<NNNN-slug>.mdand nothing else is touched for the index. No ADR.Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR with a row in the appropriate section (Open / Recently closed / Confirmed not-affected / Deferred). Not needed — no state delta: dependency bump with call-site migrations; no bug opened, closed or ruled out.Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests, except by porting Netflix's own updated assertion verbatim from upstream.Cross-backend numerical results
Not applicable: no scoring code changed.
Deep-dive deliverables (ADR-0108)
docs/migrations/v0.13.0.mdand the fix(mcp-server): asyncio.current_task() guard + sync ffprobe in async path + bare-except gather #633 commit body.AGENTS.mdinvariant note —cmd/vmafx-controller/AGENTS.md(storetest images staytag@sha256; a tag bump changes the digest in the same edit).changelog.d/changed/golusoris-v0.13.1.md.Reproducer
Known follow-ups
grpc.CompoundKeys(),core/retry, River lifecycle and drain injobs.Module, thek8s/healthreadiness drain, the observability metric catalog and its dashboard and rule generators,testutil/promcheck, gRPC client TLS from config). Moving to them is out of scope for a version bump and is tracked under the RC4 cloud-native issue (RC4 — Cloud-native platform: Postgres (CNPG) + River, two-tier cache, OCI artifacts, queue-driven scaling, generated from the API #2431).grpc.ca_file,grpc.client_auth,grpc.keepalive.*,grpc.health,grpc.client.*) are not yet reachable throughVMAFX_*variables: underscore-bearing keys need entries inapi/vmafx-platform.toml.storetestimage digests; a tag bump is manual, as it was before.Breaking changes / migration
VMAFX_HTTP_LIMITS_BODY=0onvmafx-server,vmafx-controllerorvmafx-nodeno longer removes the request-body cap; it keeps the 10 MiB default. To serve bodies of any size, setVMAFX_HTTP_LIMITS_UNLIMITED=true. No shipped chart or default sets the variable to0.