Repository navigation
fix(deps): move golang.org/x/net to v0.60.0 and Go to 1.27.2 for GO-2026-6617 and the stdlib advisories - #2651
Merged
Merged
Conversation
…026-6617 and the stdlib advisories (#2651) * fix(deps): move golang.org/x/net to v0.60.0 for GO-2026-6617 The Go vulnerability database published GO-2026-6617 (HTTP/2 server crash from an HPACK encoder race, fixed in v0.60.0). govulncheck found it reachable from the controller, the tune executor, pkg/libvmaf and tools/obssmoke, so the pre-push security hook refused every push. go vet ./... and govulncheck ./... pass after the bump. * fix(deps): move the Go toolchain to 1.27.2 for the standard-library advisories The vulnerability database release that published GO-2026-6617 also published twelve standard-library advisories (GO-2026-6599/6600/6603/6604/6605/6607/6608/ 6609/6610/6611/6612/6613), and the standard library carries GO-2026-6617 in its own HTTP/2 copy. With x/net v0.60.0 alone the CI go vet + go test job still failed at the govulncheck gate on Go 1.27.1, and so did the local pre-push security hook. Go 1.27.2 fixes all thirteen. go.mod declares go 1.27.2. RELEASE_GO_BASE and DEV_GO_BASE move to the golang:1.27-trixie digest that carries Go 1.27.2, and the Dockerfile and compose copies are rewritten by check-base-image-single-source.sh --write. The state row no longer claims govulncheck passed on 1.27.1. * build(go): pin gosec to a commit built with x/tools v0.50.0 so it reads Go 1.27.2 export data Go 1.27.2 writes export data version 5. gosec v2.29.0, the newest release, builds with x/tools v0.49.0, which reads at most version 4, so under Go 1.27.2 it reported "could not import" for every package and checked nothing. Commit 9e8e5d91f2f3 of gosec's main branch builds with x/tools v0.50.0; under Go 1.27.2 it type-checks the whole tree and reports the same five findings v2.29.0 reports on master under Go 1.27.1. Signed-off-by: Lusoris <lusoris@proton.me>
lusoris
force-pushed
the
fix/go-x-net-0.60.0
branch
from
October 9, 2026 02:11
e2dcd3b to
c5ed22b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang.org/x/netmoves from v0.59.0 to v0.60.0 and the Go toolchain from 1.27.1 to 1.27.2. GO-2026-6617 (an HTTP/2 server crash from an HPACK encoder race) was published on 2026-10-09.govulncheck ./...found it reachable fromcmd/vmafx-controller,pkg/tune/executor,pkg/libvmafandtools/obssmoke, so the pre-pushsecurityhook refused every push of the tree.The same database release published twelve standard-library advisories (GO-2026-6599, 6600, 6603, 6604, 6605, 6607, 6608, 6609, 6610, 6611, 6612 and 6613) in
html/template,net/httpand its bundled HTTP/2,crypto/tls,osandmime/multipart. The standard library also carries GO-2026-6617 in its own HTTP/2 copy. With x/net alone, the CIgo vet + go testjob still failed at the govulncheck gate on Go 1.27.1 (run 37857903681). Go 1.27.2 fixes all thirteen.go.moddeclaresgo 1.27.2.RELEASE_GO_BASEandDEV_GO_BASEinbuild-config.envmove to thegolang:1.27-trixiedigest that carries Go 1.27.2 (sha256:2f84bc93…);scripts/ci/check-base-image-single-source.sh --writerewrote the Dockerfile copies, and the observability compose file carries the same digest. Two docs pages that named Go 1.27.1 now name 1.27.2.Type
feat— new featurefix— bug fixperf— performance improvementrefactor— no behavior changedocs— documentation onlytest— test-onlybuild/ci— tooling / infraport— cherry-pick from upstream Netflix/vmafsycl/cuda/simd— backend-specificChecklist
git commit -s; fix a branch withgit rebase --signoff origin/master). See DCO sign-off.make format && make lintis green locally. Not run in full:go vet ./...,python3 scripts/ci/govulncheck-gate.py,scripts/ci/check-base-image-single-source.shand the commit and push hooks ran on the changed files.python3 scripts/ci/run_meson_test.py -- -C build. Not applicable: no C change./cross-backend-diffand the worst ULP is ≤ 2. Not applicable..c/.cpp/.cu/.h/.hpp, it has the appropriate license header (seeCONTRIBUTING.md). Not applicable.!orBREAKING CHANGE:and the migration path is documented below. Not a breaking change.docs/adr/_index_fragments/<NNNN-slug>.mdand nothing else is touched for the index. No ADR.Bug-status hygiene (ADR-0165)
docs/state.md:T-GO-X-NET-GO-2026-6617-2026-10-09added under Recently closed.Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests, except by porting Netflix's own updated assertion verbatim from upstream (value and places as upstream has them, measured against the fork's CPU build first; ADR-1828).Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants.changelog.d/security/go-x-net-0.60.0.md.Reproducer