Repository navigation
Conversation
Recreates closed PR #215's 7-file change. cpp23 Wave 8: read_json_model ported to C++23 with isolated read_json_model_cpp23_lib static lib. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
lusoris
enabled auto-merge (squash)
May 30, 2026 07:00
Contributor
Author
|
Real bug — cpp23 read_json_model conversion broke nearly every Build job + Sanitizers + Netflix Golden. Needs proper investigation, not safe for unattended train. Skipping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates closed PR #215's 7-file change. C++23 conversion of read_json_model with isolated read_json_model_cpp23_lib static lib pattern.
no docs needed: internal C++23 conversion; ADR-0846 + AGENTS.md updated in same PR.
Test plan
Deep-dive deliverables (ADR-0108)
core/AGENTS.md(in diff)meson test -C build --suite=fastchangelog.d/changed/0846-cpp23-read-json-model.md(in diff)docs/rebase-notes.md(in diff)Lint clean (CLAUDE §12 r12)
State drift (CLAUDE §12 r13)
FFmpeg-patch sync (CLAUDE §12 r14)
🤖 Generated with Claude Code