Skip to content

fix(ci): classify SPONSORS.md in the CI impact map - #2626

Merged
lusoris merged 1 commit into
masterfrom
fix/master-red-ci-impact
Oct 8, 2026
Merged

lusoris merged 1 commit into
masterfrom
fix/master-red-ci-impact

Conversation

@lusoris

@lusoris lusoris commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Summary

The Tooling Tests job (run 37793591937) passes again: SPONSORS.md, added by #2613, is a known root file in .github/ci-impact.json.

The contract test requires every tracked top-level entry to be classified so the CI planner (plan-ci-impact.py) never meets an unknown path; the new file sat beside SECURITY.md and SUPPORT.md, which are listed.

Type

  • fix — bug fix
  • build / ci — tooling / infra

Checklist

  • Commits follow Conventional Commits (the commit-msg hook enforces this).
  • Every commit is signed off (git commit -s; fix a branch with git rebase --signoff origin/master). See DCO sign-off.
  • make format && make lint is green locally. — commit hooks pass.
  • Unit tests pass: python3 scripts/ci/run_meson_test.py -- -C build. — python3 -m pytest scripts/ci/tests/test_ci_impact.py: 45 passed (master: 1 failed, ['SPONSORS.md']).
  • If I touched any SIMD/GPU code path, I ran /cross-backend-diff and the worst ULP is ≤ 2. — not applicable.
  • If I touched a feature extractor with SIMD/GPU twins, I either updated every twin or listed the gap under "Known follow-ups" below. — not applicable.
  • If I added a new .c / .cpp / .cu / .h / .hpp, it has the appropriate license header (see CONTRIBUTING.md). — no new C file.
  • If this is a breaking change, the commit message uses ! or BREAKING CHANGE: and the migration path is documented below. — not breaking.
  • If this PR adds an ADR, the ADR row lives in docs/adr/_index_fragments/<NNNN-slug>.md and nothing else is touched for the index. — no ADR.

Bug-status hygiene (ADR-0165)

  • docs/state.md updated in this PR — T-CI-IMPACT-SPONSORS-MD-UNKNOWN-2026-10-08 under Recently closed.

Netflix golden-data gate (ADR-0024)

  • I did not modify any assertAlmostEqual(...) score in the Netflix golden Python tests, except by porting Netflix's own updated assertion verbatim from upstream (value and places as upstream has them, measured against the fork's CPU build first; ADR-1828).
  • If I believe a golden value must change, I have explained why below AND pinged @lusoris for a CODEOWNERS exception. — not applicable.

No C code changed; the golden gate is unaffected.

Cross-backend numerical results

Not applicable.

Deep-dive deliverables (ADR-0108)

  • Research digest — no digest needed: trivial.
  • Decision matrix — no alternatives: only-one-way fix.
  • AGENTS.md invariant note — no rebase-sensitive invariants.
  • Reproducer / smoke-test command — below.
  • CHANGELOG fragment — no CHANGELOG fragment: not user-visible.
  • Rebase note — no rebase impact: CI and lint fix.

Reproducer

python3 -m pytest -q scripts/ci/tests/test_ci_impact.py

Known follow-ups

None.

@github-actions github-actions Bot added the type:bug Something isn't working label Oct 8, 2026
* fix(ci): classify SPONSORS.md in the CI impact map

Signed-off-by: Lusoris <lusoris@proton.me>
@lusoris
lusoris force-pushed the fix/master-red-ci-impact branch from 7d6ea38 to e83a74a Compare October 8, 2026 15:50
@lusoris
lusoris merged commit e83a74a into master Oct 8, 2026
11 of 28 checks passed
@lusoris
lusoris deleted the fix/master-red-ci-impact branch October 8, 2026 15:51
lusoris added a commit that referenced this pull request Oct 8, 2026
7a3a7d0 so #2290 lands as its own commit

The merge train's batch push of 17:41 failed after it had pushed the
stacked squashes of the batch to their pull request branches. The fixer of
skip docs/rebase-notes.d in the Markdown Lint job", #2615) also carries the
whole change of #2290 (incremental motion2 / motion3, ADR-2090) and the
CI-impact entry of #2619. #2290 never landed as its own commit, and its
code, tests, docs, changelog fragments and state rows sit under #2615's
title.

This reverts #2290's own diff (its gated head d5f18fd against its base
cfdcfb5), reverse-applied on master 0bf2996: 66 of its 68 files return
to their content before #2290; docs/state.md keeps the rows of the commits
that landed since. ADR-2090 and its index fragment stay: the ADR indexes
are written only by the landing render and link to it, so deleting it
fails the ADR link gate; #2290 re-lands without them. #2615's own change
(the Markdown Lint fragment scope) and the SPONSORS.md entry of
.github/ci-impact.json (#2626, also #2619's) stay. #2290 re-lands next as
its own squash.

docs/state.md also folds the duplicate row of the SPONSORS.md defect:
T-CI-IMPACT-SPONSORS-MD-UNKNOWN-2026-10-08 (#2626) stays and names
T-CI-IMPACT-SPONSORS-UNKNOWN-2026-10-08 (#2619, closed as a duplicate) as
its alias.

Signed-off-by: Lusoris <lusoris@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant