Repository navigation
fix(test): drop the second MALLOC_PERTURB_ entry and state row that #2548 landed twice - #2560
Merged
Merged
Conversation
lusoris
force-pushed
the
fix/dedupe-uaf-perturb-2548
branch
from
October 8, 2026 01:37
d0a3fbe to
9be6a0f
Compare
…2548 landed twice (#2560) * fix(test): drop the second MALLOC_PERTURB_ entry and state row that #2548 landed twice #2548 landed the merge train's squash of its first revision, which still carried its own MALLOC_PERTURB_=0 entry for test_gpu_picture_pool_uaf and a state row for the same bug; #2547 had already landed both. core/test/meson.build now lists the entry once (#2547's), docs/state.md keeps T-GPU-POOL-UAF-TEST-FILLS-HOST-MEMORY-2026-10-08 only, and the #2548 changelog and rebase-note fragments no longer claim that fix. Signed-off-by: Lusoris <lusoris@proton.me>
lusoris
force-pushed
the
fix/dedupe-uaf-perturb-2548
branch
from
October 8, 2026 02:16
9be6a0f to
ec72231
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reverts: #2548 (partially: drop duplicate MALLOC_PERTURB_ entry and state row)
intentional revert: drop the duplicate MALLOC_PERTURB_ entry and state row from #2548
#2548 landed the merge train's squash of its first revision (
43298360b, built before the reworkc0a0a61ed). That revision still carried its ownMALLOC_PERTURB_=0entry fortest_gpu_picture_pool_uafand a state row for the same bug, both of which #2547 had already landed. Master therefore lists the env entry twice and the bug twice.core/test/meson.build: the entry is listed once (fix(test): run the GPU pool UAF test without MALLOC_PERTURB_ so it cannot fill the host's memory #2547's).docs/state.md:T-TEST-GPU-POOL-UAF-PERTURB-OVERCOMMIT-2026-10-08is removed;T-GPU-POOL-UAF-TEST-FILLS-HOST-MEMORY-2026-10-08stays.The merge train now re-reads every PR head right before it pushes a batch and drops a PR whose head moved while it was gated (local tooling, not in this repository).
Type
fix— bug fixChecklist
check-state-md-rows.shOK,make docs-fragments-checkOK, commit hooks passed.Bug-status hygiene
docs/state.mdupdated: the duplicate row of the same closed bug is removed.Netflix golden-data gate
assertAlmostEqual(...)score in the Netflix golden Python tests.Deep-dive deliverables
AGENTS.mdinvariant note — no rebase-sensitive invariants.Reproducer