Repository navigation
fix(test): sunset legacy-runner-dependent result_test classes per ADR-0749 - #253
Merged
Merged
Conversation
…-0749 ADR-0749 removed VmafLegacyQualityRunner; PR #241 deleted exclusively-legacy tests in quality_runner_test.py but missed result_test.py. Removes ResultTest + ResultStoreTest classes (both exclusively legacy-runner driven). 4 unaffected Result test classes remain: ResultFormattingTest, ResultStoreTestWithNone, ResultAggregatingTest, ScoreAggregationTest. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #241 missed result_test.py. Removes ResultTest + ResultStoreTest (both exclusively legacy-runner). 4 other Result test classes untouched.
Test plan
Deep-dive deliverables (ADR-0108)
pytest python/test/result_test.pywas ImportErrorLint clean (CLAUDE §12 r12)
State drift (CLAUDE §12 r13)
🤖 Generated with Claude Code