Repository navigation
Conversation
…ith a stated matrix, CLI layouts (RC4 WP13, ADR-2145, ADR-2146) Work in progress: device runs, SYCL and Metal requests, docs and gates follow.
…pth, docs and state (RC4 WP13, ADR-2145, ADR-2146)
…olorimetry names (ADR-2146)
…m 8 to 16 bits, twins in step (RC4 WP13, ADR-2164)
15 of 18 tasks
lusoris
added a commit
that referenced
this pull request
Oct 7, 2026
…instead of scoring them wrongly (#2379) float_ssim, float_ms_ssim, float_adm, float_vif and float_motion normalise samples with picture_copy() on the CPU, and their GPU twins mirror it: both scale 10, 12 and 16-bit samples only and read every other depth above 8 as 8-bit bytes, so 9, 11, 13, 14 and 15-bit pictures fed through the C API got wrong scores without an error. vmaf_feature_extractor_context_init() now refuses those depths for the five families on every backend, with -EINVAL and a log line naming the extractor and the depth; psnr_hvs keeps its 9 and 11-bit support. test_read_pictures_bpc covers every family and depth and fails with the guard disabled. Full support for every depth lands in RC4 with #2378.
lusoris
force-pushed
the
rc4/api-wp13-input-formats
branch
from
October 7, 2026 06:17
c7d73cb to
6be0935
Compare
This was referenced Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLUF: RC4 WP13 follow-up (draft, stacked on #2376).
float_psnrandciedescore 9, 11, 13, 14 and 15 bits with their exact twins changed in the same PR (CUDA, HIP, SYCL; Metal refuses the new depths by name until run on a device).psnr_hvsabove 12 bits stays refused. ADR-2164.Also found and fixed:
picture_copy()(behind everyfloat_*extractor) divided by 4, 16, 256 for 10, 12, 16 bits only and read any other high depth as 8-bit bytes, sofloat_ssim,float_ms_ssim,float_adm,float_vif,float_motionreturned wrong scores for 9, 11, 13, 14, 15 bit input without an error (9 bits:float_psnr19.97 dB against 34.59 dB for the same samples at 16 bits).Failing first:
test_odd_depths_float_psnr_ciede(CPU, independent oracle: same samples at 16 bits, peak written out) fails on the old code (-EINVAL; and with onlypicture_copyreverted, the 15 dB difference). The twin parity tests fail without the twin changes (CUDA -22, HIP -22 on gfx1036). Measured with the fix:test_{cuda,hip,sycl}_float_psnr_paritybit-identical at 9, 11, 13, 14, 15 bits (noise and identical frames) andtest_{cuda,hip,sycl}_ciede_paritywithin 1e-9, on the RTX 4090, gfx1036 in the ROCm 10.1 image, and the Arc A380. Fast suite 367 ok, 0 fail. Golden gate 280 passed, 3 skipped. tidy: cpu, cuda, hip, sycl on the touched files, 0 findings.Open: Metal (
WP13-5,T-METAL-FLOAT-PSNR-ODD-DEPTHS-2026-10-07); the otherfloat_*twins at odd depths are not measured (T-FLOAT-EXTRACTORS-ODD-DEPTH-TWINS-UNMEASURED-2026-10-07).Reproduce:
python3 scripts/ci/run_meson_test.py -- -C build-cpu --suite=fast;vmaf -r a.yuv -d b.yuv -w 576 -h 324 -p 420 -b 9 -n --feature float_psnr.## Alternatives considereddocs/rebase-notes.md(the HIP constant table note is incore/src/feature/hip/AGENTS.d/ciede.md)changelog.d/fixed/float-extractors-odd-bit-depths.mddocs/rebase-notes.md