Repository navigation
docs(state): close the two Pelorus rows the vendored mirror already fixes - #2263
Merged
Merged
Conversation
…wins' debug key unsuffixed (#2265) * fix(feature): refuse a second float_adm debug instance and file the twins' debug key unsuffixed Two float_adm instances with debug=true both file the ratio under the key adm, which is never suffixed with the options because the Netflix tests read it, so the second failed the run at the first frame with "problem reading pictures". The CUDA, SYCL and HIP twins listed adm in provided_features and suffixed it, so their debug key differed from the CPU's under any option. feature_extractor_vector_append() now refuses a second context whose extractor declares the same unsuffixed_debug_key with debug set: vmaf_use_feature() returns -EINVAL and the log names the key and its holder. The CPU extractor and the four twins declare the key; the twins list adm_scale0 as the CPU does, and the twin parity cases compare the unsuffixed adm under every option. Closes T-FLOAT-ADM-DEBUG-KEY-UNSUFFIXED-2026-10-01.
…ixes (#2263) * docs(state): close the two Pelorus rows the vendored mirror already fixes The fixture that opened its CSV with fopen(path, "w") and the narrow fopen in the qp-report reader were both fixed in VMAFx/pelorus (issues 60 to 62, all closed) and re-vendored by the interop re-pin. The drift guard against a fresh clone at the pinned commit reports no drift. No new issue is needed. Closes T-PELORUS-FIXTURE-WORLD-WRITABLE-FOPEN-2026-09-18 and T-UPSTREAM-1568-WINDOWS-NARROW-PATH-API-2026-09-03.
lusoris
force-pushed
the
docs/close-pelorus-mirror-rows
branch
from
October 6, 2026 11:57
487f60d to
f0dfd0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes
T-PELORUS-FIXTURE-WORLD-WRITABLE-FOPEN-2026-09-18andT-UPSTREAM-1568-WINDOWS-NARROW-PATH-API-2026-09-03. The coordinator asked for an issue inVMAFx/pelorusfor each; verification against a fresh clone showed there is nothing left to file:VMAFx/pelorusand the issues exist and are closed: fix(ci): un-overcorrect meson setup in working-directory: core steps #60 / chore(deps): bump local CUDA 13.3 + R610 minimum driver (CI deferred) #62 (x265 CSV fixture created owner-only and exclusive, PR refactor(core): C++23 Wave 5 — cpu, ref, thread_locale (ADR-0735) #58) and chore(lint): NOLINT citation audit — ADR-0278 second closeout wave #61 (qp-report CSV paths as UTF-8 throughopen_utf8(), PR docs(research): CUDA 13.3 impact assessment for VMAFX fork #63). A search of the repository's issues for fopen / world-writable / UTF-8 / path / csv finds only those.scripts/sync-pelorus-interop.sh <fresh clone at 5f5614b>printsOK: vendored Pelorus interop ABI matches pelorus@5f5614b0229d (ABI 1.3);pelorus_qp_report_csv.chasopen_utf8()andtest_pelorus_interop.cdocuments the 0600 fixture.Reproducer
Deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants.changelog.d/changed/close-pelorus-mirror-rows.md.