Repository navigation
fix(cli): say "problem scoring picture" when libvmaf fails to score a frame - #2254
Merged
Merged
Conversation
… frame (#2254) * fix(cli): say "problem scoring picture" when libvmaf fails to score a frame vmaf_read_pictures() failing was printed as "problem reading pictures", the wording of the input read failure ("problem while reading pictures", exit 102), so an extractor refusing a frame or its options read like a broken input file. The CLI now prints "problem scoring picture N: libvmaf returned E" after the libvmaf message that names the extractor. The exit status and the read-failure wording are unchanged. The exit-code table of docs/usage/cli.md lists the case. Closes T-CLI-EXTRACTOR-ERROR-PROPAGATION-2026-10-05.
lusoris
force-pushed
the
fix/cli-extractor-error-message
branch
from
October 6, 2026 10:43
54d8bd8 to
2d8fcf3
Compare
10 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes
T-CLI-EXTRACTOR-ERROR-PROPAGATION-2026-10-05. Whenvmaf_read_pictures()failed (an extractor refusing a frame or its options, e.g.float_ms_ssimon a 16x16 picture or integer ADM refusing a viewing geometry), the CLI printedproblem reading pictures, one word away from the input read failure it prints asproblem while reading pictures(exit 102). The pictures had been read; libvmaf could not score them.core/tools/vmaf.cppprintsproblem scoring picture N: libvmaf returned Ethrough a small helper, after the libvmaf message that names the extractor. The exit status (the libvmaf code, 234 for-EINVAL) and the read-failure wording and exit 102 are unchanged.core/tools/test/test_vmaf_score_error_message.sh(suitefast, positive / negative / boundary): a refused frame gives exit 234 andproblem scoring picture 0, neither old wording appears, and a truncated input still gives exit 102 withproblem while reading pictures. On the previous binary it fails withproblem reading pictures.docs/usage/cli.mdexit-code table lists the case; the SYCL Windows and NR-metric docs quote the new line.scripts/dev/tidy-lane.sh --only core/tools/vmaf.cpp --jobs 4 cpu, clang-tidy 22.1.8);scripts/dev/preflight.sh --stage msvcismpasses.Reproducer
Deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants.changelog.d/fixed/cli-scoring-error-message.md.vmaf.cpp's frame loop, covered by the new test.docs/usage/cli.md,docs/backends/sycl/windows.md,docs/ai/models/nr_metric_v1.md.docs/state.md.