Repository navigation
fix(ci): attribute the Metal math headers to Netflix and sign tester bundles as .sigstore.json - #2061
Merged
Merged
Conversation
13 of 17 tasks
…bundles as .sigstore.json (#2061) * fix(ci): attribute the Metal math headers to Netflix and sign tester bundles as .sigstore.json Licence Provenance listed seven metal_*_math.h headers (#1921) whose EUPL-1.2 tag disagreed with the Netflix code they reproduce; five now carry the dual tag and two are recorded as reproducing none. Scorecard Signed-Releases did not count the tester bundles' .bundle signatures (it counts .sigstore.json), which with the committed eBPF object took the aggregate to 8.38 against the 8.5 floor; the tester workflows now write .sigstore.json. * fix(ci): prepend suite venv to PATH in run_affected_suites and isolate hook test python run_affected_suites.py now prepends the suite venv's bin/ directory to PATH and sets VIRTUAL_ENV so subshells and hook tests execute inside the isolated suite environment, and test_install.py prioritises sys.executable on its PATH.
lusoris
force-pushed
the
fix/master-red-lint-scorecard-2026-10-05
branch
from
October 5, 2026 06:16
c0ca5a3 to
a3aa437
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Master was red on two required checks of run set 37232274908 / 37232274888.
core/src/feature/metal/metal_*_math.hheaders (fix(metal): port the Metal twins to the exact designs of their CUDA, HIP and SYCL twins (ADR-1498) #1921, ADR-1498) wereEUPL-1.2alone although five reproduce Netflix code. Five now carry the dual tag of their CUDA/HIP/SYCL twins; two reproduce none and are[not_ports]entries with the reason; two need a[ports]entry because their names miss the family prefix.4d3792b3). Two checks dropped. Signed-Releases: the tester prereleases count as releases and their cosign bundles were named<asset>.bundle, a suffix Scorecard v5.5.0 does not count; both tester workflows now write<asset>.sigstore.json. Binary-Artifacts: the committed eBPF object (cmd/vmafx-node/bpf/rclonebypass_bpfel.o) is deliberate (ADR-0779 / ADR-1539) and stays; recorded as an open maintainer decision.run_affected_suites.pynow prepends the suite venv'sbin/directory toPATHand setsVIRTUAL_ENVso subshells and hook tests execute inside the isolated suite environment, resolvingtest_framework_migration_preserves_legacy_and_native_stages.Not fixed by a commit: the three tester prereleases already published stay unsigned in Scorecard's window until newer signed ones push them out. A maintainer can delete those disposable prereleases or sign their assets again.
Type of change
fix— bug fixbuild/ci— tooling / infraChecklist
/cross-backend-diff— not applicable: licence header comments only, no code changed.assertAlmostEqual(...)score in the Netflix golden Python tests.Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants beyond the rebase note.changelog.d/fixed/master-red-licence-scorecard-2026-10-05.md.docs/rebase-notes.md, "Metal helper-header licences and tester signature suffix".docs/state.md
docs/state.mdupdated: two closed rows and one open row (T-SCORECARD-COMMITTED-BPF-OBJECT-2026-10-05).Reproducer