Repository navigation
fix(ci): skip the CUDA parity-gate default run on a build without CUDA - #1698
Merged
Merged
Conversation
test_cuda_parity_gate_default_run is registered in the slow and gpu suites of every build. On a libvmaf built without CUDA the CLI refuses --backend cuda (ADR-0498), every gate cell reports ERROR, and the test returned the gate's exit status: a HIP-only or SYCL-only build dir had one failing test under --suite=gpu. The refusal is now a skip (exit 77), like a missing device, through one helper. test_cuda_parity_gate_skip (fast suite, device-free) formats the refusal from the string in core/tools/vmaf.cpp and checks that it is a skip, that a parity failure is not, and that a missing SYCL backend says nothing about CUDA. Closes T-CI-PARITY-GATE-DEFAULT-RUN-NO-CUDA-BUILD-2026-10-01.
9 tasks done
lusoris
force-pushed
the
fix/parity-gate-default-run-skip-no-cuda
branch
from
October 1, 2026 13:27
68b3a0e to
2487fc4
Compare
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes
T-CI-PARITY-GATE-DEFAULT-RUN-NO-CUDA-BUILD-2026-10-01(found while running--suite=fast --suite=gpuin a HIP-only build dir).test_cuda_parity_gate_default_run(added in #1676) is registered in theslowandgpusuites of every build. On a libvmaf built without CUDA the CLI refuses--backend cuda(ADR-0498), every gate cell reportsERROR, and the test returned the gate's exit status, so a HIP-only or SYCL-only build dir had one failing test: 260 OK / 1 failed onryzen-4090-arcwith-Denable_hip=true -Denable_cuda=false.The test already skipped when no CUDA device is present. A build without CUDA now skips the same way, through one helper (
cuda_unavailable()). A CUDA build on a host whose device fails to initialise still fails.core/test/test_cuda_parity_gate_skip.py(fastsuite, device-free) builds the refusal from the format string incore/tools/vmaf.cppand checks that it is a skip, that a parity failure is not, and that a missing SYCL backend says nothing about CUDA. It fails on the parent commit (3 errors).Type
fix— bug fixDeep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants.changelog.d/fixed/ci-parity-gate-default-run-skip-no-cuda.md.Reproducer
Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR:T-CI-PARITY-GATE-DEFAULT-RUN-NO-CUDA-BUILD-2026-10-01added to Recently closed.Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.