Skip to content

docs(sycl): close float_ssim combined formula residual row with measured evidence - #1684

Merged
lusoris merged 1 commit into
masterfrom
docs/sycl-float-ssim-residual
Oct 1, 2026
Merged

lusoris merged 1 commit into
masterfrom
docs/sycl-float-ssim-residual

Conversation

@lusoris

@lusoris lusoris commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes T-SYCL-FLOAT-SSIM-COMBINED-FORMULA-RESIDUAL-2026-09-29.

PR #1645 (9e9ea0571) already aligned float_ssim_sycl with CPU reference arithmetic in core/src/feature/sycl/integer_ssim_sycl.cpp (ssim_terms and ssim_term evaluate exact per-pixel $l \cdot c \cdot s$ in fp32 pairs Ff, work-group fixed-point sums term_fixed, and double host reduction).

Measurements on Intel Arc A380 (Linux xe driver)

Measured against --backend cpu on ryzen-4090-arc under sycl-a380.lock:

  • python3 scripts/ci/run_meson_test.py -- -C build test_sycl_twin_option_parity: 13/13 passed (including test_float_ssim_lcs and test_float_ssim_db_options, exact match on flat identical frames at 72.247199 dB).
  • python3 scripts/ci/run_meson_test.py -- -C build test_sycl_float_ssim_parity: 3/3 passed.
  • python3 scripts/ci/run_meson_test.py -- -C build test_sycl_float_ssim_parity_large: 3/3 passed.
  • Netflix src01_hrc00_576x324.yuv vs src01_hrc01_576x324.yuv (48 frames): max abs diff is 0.000e+00 (bit-identical to CPU).
  • BBB 4K (3840x2160, auto scale): max abs diff is 0.000e+00 (bit-identical to CPU).
  • BBB 4K (3840x2160, explicit scale=1): max abs diff is 0.000e+00 (bit-identical to CPU, down from 7.8e-5 before fix(sycl): RC3 parity follow-ups #1645).

The residual is completely gone.

Reproducer / Verification Commands

source /opt/intel/oneapi/setvars.sh >/dev/null 2>&1
flock ~/.cache/vmafx-locks/sycl-a380.lock python3 scripts/ci/run_meson_test.py -- -C build test_sycl_twin_option_parity test_sycl_float_ssim_parity test_sycl_float_ssim_parity_large

Checklist

  • Research digest — no digest needed: row closed with measured evidence of existing merged commit.
  • Decision matrix — no alternatives: row closed with measured evidence.
  • AGENTS.md invariant note — no rebase-sensitive invariants touched.
  • Reproducer / smoke-test command — pasted above under "Reproducer / Verification Commands".
  • CHANGELOG fragment — changelog.d/fixed/sycl-float-ssim-combined-formula-residual.md
  • Rebase note — docs/rebase-notes.md

…red evidence

PR #1645 (9e9ea05) already aligned float_ssim_sycl with CPU reference
arithmetic in core/src/feature/sycl/integer_ssim_sycl.cpp (ssim_terms and
ssim_term evaluate exact per-pixel l*c*s in fp32 pairs, fixed-point
work-group sums, and double host reduction).

Measured on Intel Arc A380 under Linux xe kernel driver against --backend cpu:
- Netflix 576x324 (48 frames): max abs diff 0.000e+00
- BBB 3840x2160 auto scale: max abs diff 0.000e+00
- BBB 3840x2160 scale=1: max abs diff 0.000e+00 (down from 7.8e-5 before #1645)
- Flat identical frames: exactly 72.247199 dB on both CPU and SYCL
- test_sycl_twin_option_parity passes 13/13

Closes T-SYCL-FLOAT-SSIM-COMBINED-FORMULA-RESIDUAL-2026-09-29.
@lusoris
lusoris force-pushed the docs/sycl-float-ssim-residual branch from c11fbae to f9d0922 Compare October 1, 2026 11:26
@lusoris
lusoris merged commit bd061d9 into master Oct 1, 2026
67 of 69 checks passed
@lusoris
lusoris deleted the docs/sycl-float-ssim-residual branch October 1, 2026 11:26
@github-actions github-actions Bot added the type:docs Documentation updates label Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:docs Documentation updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant