Repository navigation
chore(dev): add rc3-home-gpu-retest.sh and verification harness (ADR-1386) - #1644
Merged
Merged
Conversation
…1386) Add scripts/dev/rc3-home-gpu-retest.sh to run verify-and-time commands that docs/state.md carries for ryzen-4090-arc (RTX 4090 CUDA, Arc A380 SYCL, Zen 5 gfx1036 HIP). - Explicitly encode each command per row and backend without parsing markdown at run time. - Enforce per-device flock serialization (cuda-4090.lock, hip-gfx1036.lock, sycl-a380.lock) with clean lock acquisition and release. - Add scripts/dev/rc3_retest_helpers.py for JSON metrics comparison, median-of-N frame timing subtraction, and markdown summary generation. - Add test suite scripts/dev/tests/test_rc3_home_gpu_retest.py covering arguments, dry-run, device locking, and row ID consistency against docs/state.md. - Document usage and baseline comparison workflow in docs/development/rc3-home-gpu-retest.md and ADR-1386. - Register rc3-home-gpu-retest.sh in EXPECTED_RUNNER_PATHS in core/test/test_meson_secret_env_sanitization.py.
lusoris
force-pushed
the
chore/rc3-home-gpu-retest
branch
from
October 1, 2026 00:36
f711a33 to
00d2794
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
scripts/dev/rc3-home-gpu-retest.shand helper modulescripts/dev/rc3_retest_helpers.pyto automate verification and timing measurements for the RC3 handoff onryzen-4090-arcacross CUDA, HIP, and SYCL backends. It executes each opendocs/state.mdverify-and-time command explicitly by row ID without markdown parsing at runtime, enforces per-device flock serialization (cuda-4090.lock,hip-gfx1036.lock,sycl-a380.lock), logs per row, and produces TSV/markdown summaries with median-of-N frame timing subtraction.Type
feat— new featurefix— bug fixperf— performance improvementrefactor— no behavior changedocs— documentation onlytest— test-onlybuild/ci— tooling / infraport— cherry-pick from upstream Netflix/vmafsycl/cuda/simd— backend-specificChecklist
make format && make lintis green locally.python3 scripts/ci/run_meson_test.py -- -C build./cross-backend-diffand the worst ULP is ≤ 2..c/.cpp/.cu/.h/.hpp, it has the appropriate license header (seeCONTRIBUTING.md).!orBREAKING CHANGE:and the migration path is documented below.docs/adr/_index_fragments/<NNNN-slug>.mdand the slug is appended todocs/adr/_index_fragments/_order.txt— do not editdocs/adr/README.mddirectly (regenerated byscripts/docs/concat-adr-index.sh; see ADR-0221).Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR with a row in the appropriate section (Open / Recently closed / Confirmed not-affected / Deferred), ORno state delta: test tooling and harness scaffolding for RC3 verification.Netflix golden-data gate (ADR-0024)
assertAlmostEqual(...)score in the Netflix golden Python tests.Cross-backend numerical results
Baseline verification runs on master (
10f27efe2) onryzen-4090-arcviascripts/dev/rc3-home-gpu-retest.sh:CUDA Baseline (
master10f27ef)T-CUDA-PSNR-HVS-HOST-ROUNDTRIP-2026-09-29T-GPU-MOTION-V2-INT64-VERTICAL-2026-09-29T-CUDA-MOTION-BLUR-THEN-DIFF-2026-09-29T-CUDA-FLOAT-SSIM-SCALE-GT1-2026-09-29T-CUDA-SSIMULACRA2-HOST-COMBINE-2026-09-29T-CUDA-CAMBI-HOST-RESIDUAL-2026-09-29T-CUDA-SPEED-HOST-RESIDUAL-2026-09-29HIP Baseline (
master10f27ef)T-HIP-PSNR-HVS-HOST-CONVERT-2026-09-29T-GPU-MOTION-V2-INT64-VERTICAL-2026-09-29T-HIP-TWIN-PRIVATE-PLANE-UPLOADS-2026-09-29T-HIP-MOTION-BLUR-THEN-DIFF-2026-09-29T-HIP-FLOAT-SSIM-SCALE-GT1-2026-09-29T-HIP-SSIMULACRA2-HOST-COMBINE-2026-09-29T-HIP-CAMBI-HOST-RESIDUAL-2026-09-29T-HIP-SPEED-HOST-RESIDUAL-2026-09-29T-GPU-ADM-AIM-DEVICE-PASS-MISSING-SYCL-HIP-2026-09-05SYCL Status
T-SYCL-FP-MODEL-PRECISE-CONTRACTS-2026-09-29: Open on master (waits for PR fix(sycl): give every SYCL feature kernel the CPU's fp32 arithmetic #1630)Performance (if
perforfeat)Not applicable (tooling PR).
Deep-dive deliverables (ADR-0108)
## Alternatives considered(docs/adr/1386-rc3-home-gpu-retest-kit.md).AGENTS.mdinvariant note — added toscripts/dev/AGENTS.md.changelog.d/added/rc3-home-gpu-retest-kit.md.docs/rebase-notes.mdunderRC3-RETEST-KIT.Reproducer
Known follow-ups
None. The script will be used to measure PRs #1630, #1636, #1637, and #1639 against the above master baseline.
Breaking changes / migration
None.