Repository navigation
fix(records): triage the BUG-048 remainder and correct release notes - #1565
Merged
Merged
Conversation
Stale-branch merges removed work that the records still described as present. All 63 items in sections B-E of the silent-revert ledger were re-checked at the pre-RC1 train head: 30 are restored, 6 are moot, and the rest are filed in docs/state.md by ADR-1341 phase. GPU option parity and four performance restorations go to RC2; results stay correct because models that set a missing option keep the feature on the CPU (ADR-1183) and explicit requests fail with "unknown option". The training-script helpers go to RC3, and record debt plus three open option questions are deferred. ADR-0694's promised T-CERT-ERR33-SWEEP row is filed as well. The RC1 part is fixed here. Fourteen changelog fragments that claimed the missing work are removed, so the 1.0.0 notes no longer advertise it. The one trivial claim is made true instead: the dead integer_psnr_* aliases are dropped from extract_k150k_features.py, whose docstring no longer claims /dev/shm auto-selection. The CUDA AGENTS.md stops documenting the resolution-aware dispatch that ADR-1143 deleted, and ADR-0753 is marked superseded. Eleven VIF citations of ADR-0541 now point at ADR-0597, the number #1324 gave that decision. The ASan job runs test_pic_preallocation again. Its exclusion cited a SIGABRT that belonged to the release+LTO AVX-512 bug already fixed in the fork; under CI's exact ASan configuration the test passes 3/3.
…itation The CUDA integer_vif twin's init warning and help text now cite ADR-0597, the luma-only VIF decision, instead of the unrelated ADR-0541. Quote the warning in the option table so users can match the log line.
This was referenced Sep 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Triages everything stale-branch merges removed (BUG-048) and fixes the records that still claimed that work shipped. Without this, the 1.0.0-rc.1 release notes would advertise GPU options, performance changes and tooling that the tree does not contain.
dd51d00db): 30 restored, 6 moot, 22 missing, 5 need a decision.docs/state.mdby ADR-1341 phase:T-BUG048-GPU-OPTION-PARITY-REMAINDER-2026-09-26andT-BUG048-PERF-RESTORATIONS-2026-09-26.T-BUG048-AI-SCRIPT-HELPERS-2026-09-26.T-BUG048-RECORD-DEBT-2026-09-26(includes three option questions for the maintainer) and ADR-0694's never-filedT-CERT-ERR33-SWEEP.libvmaf.cgates onvmaf_feature_extractor_honours_options(), ADR-1183). An explicit request for the twin with that option fails with "unknown option".RC1 fixes in this PR:
changelog.dfragments that describe work not in the tree. One claim is made true instead: the deadinteger_psnr_*aliases are dropped fromextract_k150k_features.py, since libvmaf never emits such keys. The same file's docstring no longer claims automatic/dev/shmscratch selection.AGENTS.mdfrom documenting the resolution-aware dispatch that ADR-1143 deleted, and marks ADR-0753 superseded.ADR-0541at ADR-0597, the number fix(gpu): mirror the CPU integer_adm option table on the CUDA, SYCL and HIP twins #1324 gave the luma-only VIF decision; ADR-0541 is now an unrelated dev-container ADR. The source-citation registry is regenerated with its own writer.test_pic_preallocationin the ASan job again. Its exclusion cited a SIGABRT from the release+LTO AVX-512 bug the fork already fixed. Under CI's exact ASan configuration (debug,b_lto=false,b_sanitize=address) it passes 3/3.Type
Checklist
Bug-status hygiene
docs/state.mdupdated in this PR: five new open rows, two closed rows, and the ADR-1341 disposition table.Netflix golden-data gate
assertAlmostEqual(...)value was modified.Deep-dive deliverables
docs/state.mdrows).AGENTS.mdinvariant note —core/src/feature/cuda/AGENTS.mdandtools/vmaf-tune/AGENTS.mdcorrected.changelog.d/changed/release-notes-bug048-corrections.md.Reproducer