Repository navigation
docs(upstream): record what this fork has open against Netflix/vmaf - #1495
Merged
Merged
Conversation
Eight pull requests are open upstream and nothing in the tree said so, which matters at the next sync: two of them fix the same bug a fork PR fixes, and one fixes it a different way. Upstream #1601 starts the 16-bit DWT sum from the normalization offset instead of widening the accumulator to int64 as the fork's #1477 does, because the int64 form costs 3.5 to 6 % of throughput upstream. That approach is worth bringing back here, and a merge must not keep both. docs/development/known-upstream-bugs.md gains the list, each entry tied to the fork's own bug id, plus six upstream defects found while validating and not reported, so the fork does not rediscover them. Three docs/state.md rows cite the upstream pull request carrying their fix; the Netflix#1109 row records that the reporter's clips now return 404 and that nothing was asserted upstream, so there is nothing to retract. No CI has run on any of the eight: every workflow upstream waits on a maintainer approving a first-time contributor's run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fork has eight pull requests open against Netflix/vmaf and nothing in the tree said so. That matters at the next sync, because two of them fix bugs a fork PR also fixes, and one fixes it a different way.
docs/development/known-upstream-bugs.mdgains two sections:adm_cmcentre tap. All were rebased onto upstream86da14d0and re-validated there on 2026-09-19. No CI has ever run on any of them: every workflow upstream sits ataction_required.check_adm_dwt2source over-read, direct-read YUV breaking odd dimensions, frames below 17 px crashing integer ADM, a negative shift inget_best15_from32(), a zero-length variable-length array in the tool, and the SIMDadm_cmcasting its accumulator to float before dividing.The part worth acting on. Upstream #1601 fixes the 16-bit DWT overflow by starting the sum from the normalization offset rather than widening the accumulator to int64, which is what the fork's #1477 does. Upstream measured the int64 form at 3.5 to 6 % of throughput. The offset form adds no operation and measures within noise, so it is worth bringing back here, and a sync must not resolve that conflict by keeping both. Upstream #1602 makes SIMD follow scalar as the fork does, and says plainly that
float_admis closer to the unwrapped vector value, so the wrap is an artefact of the scalar reference; if upstream removes the int16 cast instead, the fork's #1474 needs revisiting.Three
docs/state.mdrows now cite the upstream pull request carrying their fix. The Netflix#1109 row records that the reporter's clips return 404 and that the frame-alignment diagnosis lived only in the fork's own docs, so there is nothing to retract upstream.One correction is recorded against the fork's own upstream work: #1589 as first submitted appended four values to the pooling enum while upstream's report writers index a four-entry name table, so every report's
pooled_metricsgot garbage keys. The fork has that guard; it was lost in the adaptation, and the first round validated with unit tests but never ran the tool. Corrected upstream on 2026-09-19.Type
docs— documentation onlyChecklist
make format && make lintis green locally.assertAlmostEqual(...)score in the Netflix golden Python tests.docs/state.mdupdated in this PR: three rows now cite the upstream pull request that carries their fix.Deep-dive deliverables (ADR-0108)
.workingdir/evidence/.AGENTS.mdinvariant note — carried indocs/rebase-notes.md, the cross-package invariant index the harness imports; it names the files whose conflicts this changes.changelog.d/changed/upstream-pr-links.md.docs/rebase-notes.md.Reproducer
Every upstream pull request number in the new section resolves to an open pull request on Netflix/vmaf.
Known follow-ups