Repository navigation
chore(deps): Update nvidia/cuda Docker tag to v13.4.1 - autoclosed - #1487
Closed
renovate[bot] wants to merge 2 commits into
Closed
renovate[bot] wants to merge 2 commits into
renovate[bot] wants to merge 2 commits into
Conversation
Merged
8 of 11 tasks
renovate
Bot
force-pushed
the
renovate/nvidia-cuda-13.x
branch
from
September 19, 2026 12:20
b6e388a to
b7b074f
Compare
7 of 11 tasks
renovate
Bot
force-pushed
the
renovate/nvidia-cuda-13.x
branch
3 times, most recently
from
September 20, 2026 19:44
e755a8b to
13619bc
Compare
This was referenced Sep 20, 2026
lusoris
added a commit
that referenced
this pull request
Sep 22, 2026
…ites Renovate could see two of the sixteen places one CUDA release is named. The base-image custom manager matches `NAME="image:tag@digest"`, so it owns CUDA_BUILDER and CUDA_RUNTIME and nothing else; #1487 moved those two tags alone, and check-base-image-single-source.sh:138 rejects an image tag that disagrees with CUDA_VERSION. That pull request was unmergeable by construction, not by accident. Rule 3 of that gate knows only the image spelling, so the rest had no drift check at all. A measured sweep finds sixteen sites across seven files in seven spellings, not the seven the report listed: the two `$cudaMajorMinor = '13.3'` literals sit one line below the `$cudaVersion` literals that were reported, and the OCI description label publishing "VMAFX production CUDA 13.3.1 runtime" was in no inventory at all — the new gate's residual sweep found it on its first run. CUDA_APT_PACKAGE had no consumer and no check, which build-config.env's own comment forbids. Renovate now owns every site it can rewrite, as one group: a custom manager resolves CUDA_VERSION, both Jimver/cuda-toolkit inputs and both $cudaVersion literals as nvidia/cuda, and a package rule groups every non-digest nvidia/cuda update as "CUDA release (coordinated pin)". extractVersion strips the flavour suffix because no bare `13.3.1` tag exists and the lookup would otherwise return nothing while looking wired. Digest-only refreshes stay in the auto-merged Docker digests batch. The five spellings Renovate cannot write belong to scripts/ci/check-cuda-pin-lockstep.py, which checks all sixteen against CUDA_VERSION, derives those five with --write (make cuda-pin-sync), and fails on a CUDA release literal in any spelling it does not recognise. Renovate substitutes the whole looked-up version into the slot it matched, so it would write `13.4.0` where `13.4` or `13-4` belongs; autoReplaceStringTemplate does not reach these shapes because confirmIfDepUpdated compares the rendered template against the re-extracted currentValue and reverts the write when they differ (read from Renovate 44.103.6's own dist/, recorded in the digest). Verified: 12 tests in scripts/ci/tests/test_cuda_pin_single_source.py, which fail when the group rule is removed or the manager's file patterns are narrowed; renovate.json validates against Renovate 44.103.6; the gate reports 16 sites clean and catches drift in each spelling. Not verified: no Renovate run was performed, so the grouped pull request itself has not been observed — that needs a token and the registry. The CUDA version bump is a separate change and is not in this commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
renovate
Bot
force-pushed
the
renovate/nvidia-cuda-13.x
branch
from
September 22, 2026 16:02
13619bc to
5f6c6c7
Compare
renovate
Bot
force-pushed
the
renovate/nvidia-cuda-13.x
branch
from
September 22, 2026 17:04
5f6c6c7 to
6b43ca5
Compare
lusoris
marked this pull request as ready for review
September 22, 2026 17:41
renovate
Bot
changed the title
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
13.3.1-runtime-ubuntu26.04→13.4.1-runtime-ubuntu26.0413.3.1-devel-ubuntu26.04→13.4.1-devel-ubuntu26.0413.3.1-devel-ubuntu26.04→13.4.1-devel-ubuntu26.04Configuration
📅 Schedule: (in timezone Europe/Vienna)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.