fix: clear the -Denable_asm=false and aarch64 build warnings, and lint vif_neon.c to zero

.standards-baseline.json

@@ -1,9 +1,9 @@
 {
   "version": 1,
-  "generated_at": "2026-09-18T18:37:56Z",
+  "generated_at": "2026-09-18T20:31:14Z",
   "repository": "",
   "commit_sha": "",
-  "total_infractions": 1627,
+  "total_infractions": 1623,
   "infractions": [
     {
       "rule_id": "HISS-04",
@@ -2717,38 +2717,6 @@
       "message": "Function '{' (114 LOC) exceeds HISS-04 / NASA Rule 4 limit of 60 LOC",
       "fingerprint": "core/src/feature/arm64/ssimulacra2_sve2.c:673:HISS-04"
     },
-    {
-      "rule_id": "HISS-04",
-      "file_path": "core/src/feature/arm64/vif_neon.c",
-      "line_number": 292,
-      "symbol": "vif_subsample_rd_8_neon",
-      "message": "Function 'vif_subsample_rd_8_neon' (132 LOC) exceeds HISS-04 / NASA Rule 4 limit of 60 LOC",
-      "fingerprint": "core/src/feature/arm64/vif_neon.c:292:HISS-04"
-    },
-    {
-      "rule_id": "HISS-04",
-      "file_path": "core/src/feature/arm64/vif_neon.c",
-      "line_number": 427,
-      "symbol": "{",
-      "message": "Function '{' (137 LOC) exceeds HISS-04 / NASA Rule 4 limit of 60 LOC",
-      "fingerprint": "core/src/feature/arm64/vif_neon.c:427:HISS-04"
-    },
-    {
-      "rule_id": "HISS-04",
-      "file_path": "core/src/feature/arm64/vif_neon.c",
-      "line_number": 566,
-      "symbol": "vif_statistic_8_neon",
-      "message": "Function 'vif_statistic_8_neon' (326 LOC) exceeds HISS-04 / NASA Rule 4 limit of 60 LOC",
-      "fingerprint": "core/src/feature/arm64/vif_neon.c:566:HISS-04"
-    },
-    {
-      "rule_id": "HISS-04",
-      "file_path": "core/src/feature/arm64/vif_neon.c",
-      "line_number": 895,
-      "symbol": "{",
-      "message": "Function '{' (326 LOC) exceeds HISS-04 / NASA Rule 4 limit of 60 LOC",
-      "fingerprint": "core/src/feature/arm64/vif_neon.c:895:HISS-04"
-    },
     {
       "rule_id": "HISS-04",
       "file_path": "core/src/feature/brisque_math.h",
@@ -9777,10 +9745,10 @@
     {
       "rule_id": "HISS-04",
       "file_path": "core/test/test_psnr_hvs_simd.c",
-      "line_number": 157,
+      "line_number": 164,
       "symbol": "{",
       "message": "Function '{' (115 LOC) exceeds HISS-04 / NASA Rule 4 limit of 60 LOC",
-      "fingerprint": "core/test/test_psnr_hvs_simd.c:157:HISS-04"
+      "fingerprint": "core/test/test_psnr_hvs_simd.c:164:HISS-04"
     },
     {
       "rule_id": "HISS-04",
@@ -9809,18 +9777,18 @@
     {
       "rule_id": "HISS-04",
       "file_path": "core/test/test_ssimulacra2_simd.c",
-      "line_number": 758,
+      "line_number": 768,
       "symbol": "{",
       "message": "Function '{' (76 LOC) exceeds HISS-04 / NASA Rule 4 limit of 60 LOC",
-      "fingerprint": "core/test/test_ssimulacra2_simd.c:758:HISS-04"
+      "fingerprint": "core/test/test_ssimulacra2_simd.c:768:HISS-04"
     },
     {
       "rule_id": "HISS-04",
       "file_path": "core/test/test_ssimulacra2_simd.c",
-      "line_number": 864,
+      "line_number": 874,
       "symbol": "test_ptlr_one",
       "message": "Function 'test_ptlr_one' (104 LOC) exceeds HISS-04 / NASA Rule 4 limit of 60 LOC",
-      "fingerprint": "core/test/test_ssimulacra2_simd.c:864:HISS-04"
+      "fingerprint": "core/test/test_ssimulacra2_simd.c:874:HISS-04"
     },
     {
       "rule_id": "HISS-04",

CHANGELOG.md

@@ -25440,6 +25440,23 @@ results") and updated `BISECT_TRACKER_ISSUE` to `"827"`. Also improved
 making future API errors diagnosable in CI logs.
 
 
+**Cleared `-Wunused-function` / `-Wunused-const-variable` / `-Wunused-variable`
+warnings in a `-Denable_asm=false` build** — ten SIMD parity-test files under
+`core/test/` defined scalar-reference helpers, fixture builders, and lookup
+tables unconditionally while every caller sat under an ISA guard (`ARCH_X86`,
+`HAVE_AVX512`, `ARCH_AARCH64`, or their union). A build with SIMD disabled
+compiled the helpers in with zero remaining callers and warned on all ~30 of
+them: `test_vif_simd.c`, `test_ssimulacra2_simd.c`, `test_speed_simd.c`,
+`test_psnr_hvs_simd.c`, `test_ms_ssim_decimate.c`, `test_motion_v2_simd.c`,
+`test_iqa_convolve.c`, `test_integer_ssim_simd.c`, `test_cambi_simd.c`, and
+`test_cambi.c`. Each helper now sits under the same preprocessor condition as
+its callers (widened to the union where a helper is shared across the x86 and
+aarch64 paths); nothing was deleted and no `(void)`-cast or
+`[[maybe_unused]]` suppression was used. Verified zero warnings and an
+identical test count on a `-Denable_asm=false` x86-64 build, the default
+x86-64 build, and an aarch64 cross build under `qemu-aarch64-static`.
+
+
 - The dev container no longer becomes unbuildable when `code.ffmpeg.org` is down. The
   nv-codec-headers layer now falls back to `github.com/FFmpeg/nv-codec-headers` for the same
   pinned tag, and asserts the archive actually carries `ffnvcodec/dynlink_cuda.h` and the

changelog.d/fixed/no-asm-simd-test-unused-warnings.md

@@ -0,0 +1,15 @@
+**Cleared `-Wunused-function` / `-Wunused-const-variable` / `-Wunused-variable`
+warnings in a `-Denable_asm=false` build** — ten SIMD parity-test files under
+`core/test/` defined scalar-reference helpers, fixture builders, and lookup
+tables unconditionally while every caller sat under an ISA guard (`ARCH_X86`,
+`HAVE_AVX512`, `ARCH_AARCH64`, or their union). A build with SIMD disabled
+compiled the helpers in with zero remaining callers and warned on all ~30 of
+them: `test_vif_simd.c`, `test_ssimulacra2_simd.c`, `test_speed_simd.c`,
+`test_psnr_hvs_simd.c`, `test_ms_ssim_decimate.c`, `test_motion_v2_simd.c`,
+`test_iqa_convolve.c`, `test_integer_ssim_simd.c`, `test_cambi_simd.c`, and
+`test_cambi.c`. Each helper now sits under the same preprocessor condition as
+its callers (widened to the union where a helper is shared across the x86 and
+aarch64 paths); nothing was deleted and no `(void)`-cast or
+`[[maybe_unused]]` suppression was used. Verified zero warnings and an
+identical test count on a `-Denable_asm=false` x86-64 build, the default
+x86-64 build, and an aarch64 cross build under `qemu-aarch64-static`.