Repository navigation
Conversation
T-METAL-MOTION-V2-MIRROR-OFF-BY-ONE-2026-09-03 was filed on 2026-09-03 against `core/src/feature/metal/integer_motion_v2.metal` for folding the high boundary with `2 * sup - idx - 1` instead of the scalar reflect-101 `2 * size - idx - 2`. The defect was fixed one day later by 71da046 (PR #1223, ADR-1166), which replaced the helper with the iterated fold `2 * (sup - 1) - idx` -- algebraically the CPU form -- and thereby also removed the residual out-of-range single-bounce read on small dimensions. The ledger row was never updated, so the bug read as open on master. Move the row from 'Open bugs' to 'Recently closed' (exactly one row per bug id) with the verification recorded, and rewrite the file's top-of-file block comment, which still described the removed `- 1` convention and contradicted the corrected `mv2_mirror` comment below it. No code path reads the comment; scores, snapshots and the Netflix golden gate are unaffected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #1294, which covers the same bug more completely. Both close Closing this one; #1294 carries the fix. |
lusoris
deleted the
docs/close-t-metal-motion-v2-mirror-off-by-one-2026
branch
September 18, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
T-METAL-MOTION-V2-MIRROR-OFF-BY-ONE-2026-09-03was still listed under "Open bugs" indocs/state.md, but the defect it describes was fixed on master a day after the row was written. This PR corrects the ledger (moves the row to "Recently closed" with the verification recorded) and rewrites the one stale artefact the fix left behind: the top-of-file block comment incore/src/feature/metal/integer_motion_v2.metal, which still described the removed mirror convention and contradicted the correctedmv2_mirrorcomment directly below it. No Metal code path reads the comment; scores, snapshots and the Netflix golden gate are untouched.Verification that the bug is not open
The row claimed the Metal fold used
2 * sup - idx - 1(which repeats the boundary row) while the scalarcore/src/feature/integer_motion_v2.c:157and the CUDA twin use reflect-1012 * size - idx - 2. Atorigin/masterthe helper is:2 * (sup - 1) - idxis algebraically identical to the CPU's2 * size - idx - 2, so the convention already matches, and the iterated fold additionally removes the single-bounce out-of-range read on small dimensions.git log --oneline origin/master -- core/src/feature/metal/integer_motion_v2.metalshows the change landed in71da046db— "fix(core): harvest and fix nine stale upstream Netflix/vmaf reports (ADR-1166)" (PR #1223, 2026-09-04). The ledger row was written 2026-09-03 and never updated.The remaining Apple-hardware
/cross-backend-diffplaces=4 confirmation is owner-driven and is tracked by the standing Metal validation gaps, not by this numeric-parity row.Type
docs— documentation onlyChecklist
pre-commit run --files <touched>is green locally (no compiled surface changed; the only C-family edit is a block comment).assertAlmostEqual(...)score in the Netflix golden Python tests.Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR — the row is moved (not copied) from "Open bugs" to "Recently closed", leaving exactly one row for the bug id, with the closing commit71da046dbcited.Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants.changelog.d/fixed/metal-motion-v2-mirror-header-comment.md;CHANGELOG.mdre-rendered byscripts/release/concat-changelog-fragments.sh --write.Reproducer
Known follow-ups
/cross-backend-diff(places=4) for every Metal extractor remains outstanding; it is a hardware-access gap, not a known defect.