Repository navigation
Conversation
T-SPEED-GPU-REGISTRY-ORPHAN-2026-06-19 was already fixed on master by commit a0bf83c (PR #1004): the six GPU SpEED registrations (speed_{chroma,temporal}_{cuda,sycl,hip}) were ported from the dead core/src/feature/feature_extractor.c twin into feature_extractor.cpp and the dead .c file was deleted. The ledger, however, carried the bug twice in "Recently closed" plus two identical tombstone comments in "Open bugs", so a fresh session could read it as unsettled. Collapse to exactly one row per bug id and record the re-verification against origin/master: only feature_extractor.cpp / .h exist under core/src/feature/; the externs sit at lines 105-106 (CUDA), 134-135 (SYCL), 216-217 (HIP); the registry entries at lines 310 (SYCL), 327 (CUDA), 405 (HIP), each inside its backend guard; the CPU twins remain registered unconditionally at line 276. Later touches (300423b, fcae339) did not remove them. Ledger-only change; no source, build or test behaviour is affected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #1322, which merged first.
Rebasing this would either be a no-op or re-add a second row, which the gate #1322 introduced ( |
lusoris
deleted the
docs/close-t-speed-gpu-registry-orphan-2026-06-19
branch
September 18, 2026 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ledger-only correction.
T-SPEED-GPU-REGISTRY-ORPHAN-2026-06-19was fixed on master long ago by commita0bf83c214(PR #1004), butdocs/state.mdcarried the bug twice in "Recently closed" and kept two identical tombstone comments in "Open bugs". A session reading the ledger cold could take that as unsettled and re-investigate. This PR collapses it to exactly one row per bug id and records the fresh re-verification againstorigin/master. No source, build, or test behaviour changes.Verified at
origin/master(not taken from the ledger prose):git ls-tree origin/master core/src/feature/ | grep -i feature_extractor→ onlyfeature_extractor.cppandfeature_extractor.h; the dead.ctwin is gone.vmaf_fex_speed_{chroma,temporal}_cuda), 134-135 (_sycl), 216-217 (_hip).#if HAVE_SYCL), 327 (#if HAVE_CUDA), 405 (#if HAVE_HIP) — each verified to sit before the matching#endif. CPU twins registered unconditionally at line 276.300423b9eandfcae339b5did not remove them.So
vmaf_get_feature_extractor_by_name("speed_chroma_cuda" | "speed_temporal_cuda" |…_sycl|…_hip")` resolves on a build with the matching backend enabled.Type
docs— documentation onlyChecklist
pre-commit run --filesgreen on every touched file (markdownlint, dispatch-registry check, secret scan).assertAlmostEqual(...)score in the Netflix golden Python tests.Bug-status hygiene (ADR-0165)
docs/state.mdupdated in this PR — the duplicate "Recently closed" row and the duplicate tombstone comment are removed; the surviving row is rewritten in past tense citing commita0bf83c214(PR fix(registry): restore orphaned GPU SpEED registrations + delete dead feature_extractor.c #1004) plus the 2026-09-06 re-verification.Netflix golden-data gate (ADR-0024)
docs/state.md,CHANGELOG.md(rendered) and onechangelog.d/fragment.Deep-dive deliverables (ADR-0108)
AGENTS.mdinvariant note — no rebase-sensitive invariants.changelog.d/fixed/t-speed-gpu-registry-orphan-ledger-dedup.md;CHANGELOG.mdregenerated withbash scripts/release/concat-changelog-fragments.sh --write.Reproducer
Known follow-ups
None.
T-CUDA-INIT-SUBMIT-LEAKS-2026-06-19also has both an open row and a tombstone comment indocs/state.md; that one is a separate bug id and is deliberately left untouched here.