Repository navigation
Conversation
lusoris
marked this pull request as ready for review
May 29, 2026 10:05
lusoris
enabled auto-merge (squash)
May 29, 2026 10:05
6 of 9 tasks
lusoris
disabled auto-merge
May 29, 2026 11:50
lusoris
marked this pull request as draft
May 29, 2026 11:50
…spatch_env (ADR-0768) Convert three small core/src/*.c files to C++23, continuing the ADR-0708 migration playbook (isolated static_library per TU, cpp_std=c++23 scoped): - picture_pool.cpp: typedef struct → struct, nullptr, static_cast / reinterpret_cast for the C-style first-member inheritance pattern (PooledPicturePriv ↔ VmafPicturePrivate). - gpu_picture_pool.cpp: typedef struct → struct, nullptr, std::malloc / std::memset, std::free. - gpu_dispatch_env.cpp: constexpr table cap, nullptr, std::strcmp / std::getenv. Collateral: extern "C" guards added to picture.h, mem.h, ref.h, and picture_pool.h so the new C++ TUs resolve unmangled C symbols at link time. Orphan test_ansnr_simd meson entry (deleted source, ADR-0720 fallout) removed. All 25 gpu_picture_pool.c references in test/meson.build updated to .cpp. Build: 724 targets. Fast tests: 50/50 pass. No user-discoverable surface change (internal build wiring only). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lusoris
force-pushed
the
feat/cpp23-wave9-bundle-20260529
branch
from
May 29, 2026 12:08
14c9791 to
46e7193
Compare
lusoris
marked this pull request as ready for review
May 31, 2026 13:49
Contributor
Author
|
Superseded by master merge marathon 2026-05-31. |
Contributor
Author
|
Closing in favor of rebased PR from branch rebase/cpp23-wave9-pr124. The gpu_dispatch_env conversion was already merged in PR #531 (ADR-0858); this rebase carries only the picture_pool and gpu_picture_pool conversions. |
6 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
picture_pool.c,gpu_picture_pool.c, andgpu_dispatch_env.cto C++23, each in an isolatedstatic_librarywithoverride_options: ['cpp_std=c++23'](ADR-0708 pattern).extern "C"guards topicture.h,mem.h,ref.h, andpicture_pool.hso new C++ TUs resolve unmangled C symbols at link time.test_ansnr_simdmeson entry (source file deleted by PR feat(core): drop legacy ansnr feature (pre-VMAF, never Netflix-adopted) #38 / ADR-0720, entry never cleaned up).'../src/gpu_picture_pool.c'references incore/test/meson.buildto.cpp.Changes
core/src/gpu_dispatch_env.cto.cppconstexprtable cap,nullptr,std::strcmp/std::getenvcore/src/gpu_picture_pool.cto.cppstruct(no typedef),nullptr,std::malloc/std::freecore/src/picture_pool.cto.cppstruct,nullptr,reinterpret_castfor C-style first-member inheritance,std::malloc/std::freecore/src/picture.hextern "C"guards added around function declarationscore/src/mem.hextern "C"guards addedcore/src/ref.hextern "C"guards addedcore/src/picture_pool.hextern "C"guards addedcore/src/meson.build.csources replaced by three isolatedcpp_std=c++23static libscore/test/meson.build.cupdated to.cppforgpu_picture_pool; orphantest_ansnr_simdremovedSmoke-test command
Deliverables checklist (ADR-0108)
## Alternatives consideredtabledocs/rebase-notes.mdchangelog.d/changed/cpp23-wave9-pool-env.mddocs/rebase-notes.md🤖 Generated with Claude Code