Repository navigation
Conversation
3 tasks
…so.4 Scoping document and research digest for the authorized VMAFx v4.0.0 ABI break. No source changes — design approval gate only. Deliverables: - docs/adr/0767-phase-4b8-c-abi-break-scoping.md (ADR, Proposed) - docs/research/research-0752-phase-4b8-c-abi-break-scoping.md (full symbol inventory across 14 public headers + 15 ffmpeg-patch callsite tables, 9 proposed breaking changes, v4 migration guide outline, test plan, ffmpeg-patches rewrite plan) - docs/adr/README.md — index row added - docs/rebase-notes.md — entry added - changelog.d/changed/0767-phase-4b8-c-abi-break-scoping.md Breaking changes proposed for v4.0.0: 1. Config structs from pass-by-value to const* 2. Remove vmaf_write_output (superseded by vmaf_write_output_with_format) 3. Remove vmaf_model_load string-lookup (use vmaf_model_version_next + new vmaf_model_load_builtin) 4. void->int return for destroy/free/close family 5. Rename vmaf_sycl_picture_fetch -> vmaf_sycl_fetch_preallocated_picture 6. Move vmaf_read_pictures_sycl/vmaf_flush_sycl to libvmaf_sycl.h 7. Add vmaf_context_get_backend + VmafBackend enum 8. ffmpeg-patches 0001-0015 rewrite in lockstep (CLAUDE.md 12 r14) DO NOT MERGE -- requires user review before implementation begins. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lusoris
force-pushed
the
worktree-agent-ae269c3d3818cdc79
branch
from
May 29, 2026 12:08
b87d4ee to
f437401
Compare
lusoris
marked this pull request as ready for review
May 31, 2026 13:50
Contributor
Author
|
Superseded by master merge marathon 2026-05-31. |
Contributor
Author
|
Closing in favor of rebased PR from branch c-abi-break-0767-rebase (conflict-free, pre-commit clean). |
6 tasks done
lusoris
added a commit
that referenced
this pull request
Jun 3, 2026
Scoping document and research digest for the authorized VMAFx v4.0.0 ABI break. No source changes — design approval gate only. Deliverables: - docs/adr/0767-phase-4b8-c-abi-break-scoping.md (ADR, Proposed) - docs/research/research-0752-phase-4b8-c-abi-break-scoping.md (full symbol inventory across 14 public headers + 15 ffmpeg-patch callsite tables, 9 proposed breaking changes, v4 migration guide outline, test plan, ffmpeg-patches rewrite plan) - docs/adr/README.md — index row added - docs/rebase-notes.md — entry added - changelog.d/changed/0767-phase-4b8-c-abi-break-scoping.md Breaking changes proposed for v4.0.0: 1. Config structs from pass-by-value to const* 2. Remove vmaf_write_output (superseded by vmaf_write_output_with_format) 3. Remove vmaf_model_load string-lookup (use vmaf_model_version_next + new vmaf_model_load_builtin) 4. void->int return for destroy/free/close family 5. Rename vmaf_sycl_picture_fetch -> vmaf_sycl_fetch_preallocated_picture 6. Move vmaf_read_pictures_sycl/vmaf_flush_sycl to libvmaf_sycl.h 7. Add vmaf_context_get_backend + VmafBackend enum 8. ffmpeg-patches 0001-0015 rewrite in lockstep (CLAUDE.md 12 r14) Rebased from PR #109 (05-29 vintage) onto current master. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lusoris
added a commit
that referenced
this pull request
Jun 3, 2026
…#561) Scoping document and research digest for the authorized VMAFx v4.0.0 ABI break. No source changes — design approval gate only. Deliverables: - docs/adr/0767-phase-4b8-c-abi-break-scoping.md (ADR, Proposed) - docs/research/research-0752-phase-4b8-c-abi-break-scoping.md (full symbol inventory across 14 public headers + 15 ffmpeg-patch callsite tables, 9 proposed breaking changes, v4 migration guide outline, test plan, ffmpeg-patches rewrite plan) - docs/adr/README.md — index row added - docs/rebase-notes.md — entry added - changelog.d/changed/0767-phase-4b8-c-abi-break-scoping.md Breaking changes proposed for v4.0.0: 1. Config structs from pass-by-value to const* 2. Remove vmaf_write_output (superseded by vmaf_write_output_with_format) 3. Remove vmaf_model_load string-lookup (use vmaf_model_version_next + new vmaf_model_load_builtin) 4. void->int return for destroy/free/close family 5. Rename vmaf_sycl_picture_fetch -> vmaf_sycl_fetch_preallocated_picture 6. Move vmaf_read_pictures_sycl/vmaf_flush_sycl to libvmaf_sycl.h 7. Add vmaf_context_get_backend + VmafBackend enum 8. ffmpeg-patches 0001-0015 rewrite in lockstep (CLAUDE.md 12 r14) Rebased from PR #109 (05-29 vintage) onto current master. Co-authored-by: Lusoris <lusoris@pm.me> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is in this PR
docs/adr/0767-phase-4b8-c-abi-break-scoping.md— ADR (status: Proposed)docs/research/research-0752-phase-4b8-c-abi-break-scoping.md— complete scoping digest:Proposed breaking changes (summary)
vmaf_write_outputvmaf_write_output_with_format(ADR-0119)vmaf_model_loadstring-lookupvmaf_model_version_next+vmaf_model_load_builtinvoid→intfor destroy/free/close familyvmaf_sycl_picture_fetchlibvmaf_sycl.hvmaf_context_get_backendNetflix golden assertions
Unaffected — they are CLI tests, not C ABI tests.
Deliverables checklist (ADR-0108)
docs/research/research-0752-phase-4b8-c-abi-break-scoping.md## Alternatives consideredAGENTS.mdinvariant note: no rebase-sensitive invariants (doc-only PR)changelog.d/changed/0767-phase-4b8-c-abi-break-scoping.mddocs/rebase-notes.md🤖 Generated with Claude Code