Repository navigation
fix(build,hip): round-3 batch — HIP vif uninit-err + NVTX libdl + icx ssim fp-model (R3-6/9/10) - #1062
Merged
Conversation
…sim fp-model (R3-6/9/10)
R3-6 HIP integer_vif init: declare int err=0 early (fail_stream/fail_submit
returned uninitialized). R3-9 NVTX: cc.find_library('dl') not empty
shared_library('dl'). R3-10 ssim AVX2 carve-out: + _x86_simd_strict_fp_extra
(icx -fp-model=precise; no-op gcc/clang → golden unchanged). R2-6 icpx-motion
deferred (needs scoped motion carve-out). meson libvmaf 3.2.0; CPU 1280/1280.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
lusoris
added a commit
that referenced
this pull request
Sep 16, 2026
22 inline code-scanning findings on #1425, triaged one at a time rather than dismissed or suppressed in bulk. Five are real: - `read_luma8()` guarded `shift == 0` after the `bitdepth == 8` case had already returned, so the arm was unreachable. Removing it also makes visible that `shift` is 2, 4 or 8 there and `shift - 1U` cannot underflow. - `check_filtered_center()` and `check_spatial_mask_first_image()` took `VmafPicture` by value and then took its address; both take a pointer. - `test_vif_lifecycle.c` and `test_vmaf_roi_bounds.c` compared floats with `==`. Exact equality is the *intent* — bit-exact frame differencing, exactly symmetric saliency — so loosening them to a tolerance would hide the defect they exist to catch. They now compare bit patterns, the same shape `test_feature_isa_invariance.c` already documents for the same reason. Fifteen are false positives, each checked rather than assumed: - every `cpp/unused-static-function` hit is called. The `pdjson.c` helpers are called directly; `json_begin_error` only through the `json_error()` macro; the thread-pool helpers through `#define pthread_create observed_create` combined with `#include "../src/thread_pool.c"`, an interposition CodeQL cannot follow. gcc with `-Wunused-function` reports none of them. - the `cpp/constant-comparison` hits in `feature_extractor.cpp` and `fex_ctx_vector_internal.h` are `SIZE_MAX / sizeof(T)` overflow guards. They are provably dead on 64-bit, which is what CodeQL sees, and live on i686 — a target `libvmaf-build-matrix.yml` gates. Deleting them to quiet a note would be a real 32-bit regression. The two Semgrep findings are #1062/#1063, already dismissed earlier; their PR comments are stale, because GitHub applies an in-source suppression only at alert-creation time. 148/148 tests pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-3 build/GPU error-path fixes (golden-safe). R3-6 HIP integer_vif uninitialized err code; R3-9 NVTX empty libdl target → cc.find_library; R3-10 SSIM AVX2 carve-out missing icx strict-fp. CPU build 1280/1280, libvmaf 3.2.0. R2-6 icpx-motion deferred (needs scoped motion carve-out).
no docs needed: build-system + GPU error-path bug fixes, no user-discoverable surface.
🤖 Generated with Claude Code