feat: on stats parsed callback #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.13.0-tt-212-on-parsed-stats.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
desher
reviewed
Nov 26, 2024
src/WebRTCIssueDetector.ts
Outdated
| @@ -133,7 +140,7 @@ class WebRTCIssueDetector { | |||
| this.statsReporter.stopReporting(); | |||
| } | |||
|
|
|||
| public handleNewPeerConnection(pc: RTCPeerConnection): void { | |||
| public handleNewPeerConnection({ pc, id }: { pc: RTCPeerConnection, id?: string }): void { | |||
There was a problem hiding this comment.
I would recommend not adding a new id property here, since RTCPeerConnection identifier is not in the spec and it may be confusing for those who do not use it.
The problem could be solved with a simple decorator with id property around RTCPeerConnection on a client side.
There was a problem hiding this comment.
Fixed contract break, changes are now backwards compatible
…webrtc-issue-detector into tt-212-on-parsed-stats
|
🎉 This PR is included in version 1.13.0-tt-212-on-parsed-stats.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
desher
approved these changes
Nov 29, 2024
evgmel
approved these changes
Nov 29, 2024
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.