Some stupid tests #9
Conversation
|
Not sure what values do these tests add, especially the last one where all the contents are commented? The "race" tests don't seem to be testing that the results have actually been written anywhere as well as doing just one iteration is probably not enough. |
|
Feel free to reject/close it, it's just some examples for race detection, and yes they are badly written |
There was a problem hiding this comment.
Please make sure you're actually checking not only lack of panics during concurrent writes but also that all results were written correctly. Otherwise this test is misleading and gives you the impression that this code works whereas even empty body for Write() func would pass this test. Please also remove all empty files / commented code ones or provide explanation on why those files are needed and what they're actually testing. Thanks
| file := "table1" | ||
| const len = 4 | ||
|
|
||
| append := func(i int) { |
There was a problem hiding this comment.
Suggest to use another name for func. It is not recommended to use go reserved names
for race detection, for example