Skip to content

Conversation

@simonprovost
Copy link
Member

Hi @roquelopez

I hope you’re well! After the email discussions, I looked at the code. I saw your changes and thought hopefully I could give a slight help :) !

Changes invove running a pyproject.toml over a setup.py (modern Pythonic libraries packaging), which may motivate a potential release to PyPI. It also includes UV-managed support, the popular fast Ruff static analyser, and a pre-commit as the project’s first development tooling. This ensures the codebase style remains consistent after further devs. Finally, it adds a pre-commit as a Github workflow along with passing a Ruff check. Additionally, I’ve added nice Github issues templates for reporting any issues in a better manner than with plain template.

See a video of showing the templates visually below:

IssuesCompressed.mp4

Cheers!

@simonprovost simonprovost changed the title chore: switch to pdm-backend + uv; add Ruff + pre-commit UV-managed & More Pythonic-PyPi ready refactoring W/ Pre-Commit Sep 18, 2025
@roquelopez
Copy link
Contributor

Hi @simonprovost, thanks a lot for opening this PR! Overall, it looks good to me. I usually rely on black for code formatting, but I see that Ruff has additional features, which could be very useful. I also like the GitHub issue templates, I’ve seen them in other projects and they really help simplify and standardize issue descriptions. Feel free to merge it

@roquelopez roquelopez self-assigned this Sep 19, 2025
@simonprovost
Copy link
Member Author

Hi @simonprovost, thanks a lot for opening this PR! Overall, it looks good to me. I usually rely on black for code formatting, but I see that Ruff has additional features, which could be very useful. I also like the GitHub issue templates, I’ve seen them in other projects and they really help simplify and standardize issue descriptions. Feel free to merge it

So cool @roquelopez !! thanks so much for the kind words. I do not think having the right to merge on this repo interestingly enough, may you do it or grants me the right to review and merge, please?

As soon as this is merged, I'll rebase #4 .

Cheers

@simonprovost simonprovost merged commit 8608a36 into VIDA-NYU:main Sep 20, 2025
@simonprovost simonprovost deleted the feat/uv_python_lib_migration branch September 20, 2025 21:25
@julianafreire
Copy link
Member

This is cool, thanks Simon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants